[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #609: MINIFICPP-962 - C2 tests should use random port

[GitBox <gi...@apache.org>]

bakaid commented on a change in pull request #609: MINIFICPP-962 - C2 tests should use random port
URL: https://github.com/apache/nifi-minifi-cpp/pull/609#discussion_r302633415
 
 

 ##########
 File path: extensions/http-curl/tests/C2VerifyHeartbeatAndStop.cpp
 ##########
 @@ -162,12 +162,14 @@ class VerifyC2Heartbeat : public CoapIntegrationBase {
     std::string url = "";
     inv->getProperty(minifi::processors::InvokeHTTP::URL.getName(), url);
 
+    std::string c2_url = std::string("http") + (isSecure ? "s" : "") + "://localhost:" + getWebPort() + "/api/heartbeat" ;
 
 Review comment:
   Is this new functionality? I don't see https in this case before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services