You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/16 23:16:29 UTC
[GitHub] mistercrunch commented on issue #5021: Allow MetricsControl to
aggregate on a column with an expression
mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389695239
I'm not 100% but I'm pretty sure Druid postaggs have to be made out of metrics.
Your PR LGTM, I'd be great to have a unit test that was failing before and succeeding now. For example we could have a new expression in the "births" dataset that would be called `first_letter` as `substr(name, 1, 1)` and do a count distinct of that or something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org