You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/02/27 10:20:19 UTC

[PR] [SPARK-47185][SS][TESTS] Increase timeout between actions in KafkaContinuousSourceSuite [spark]

HyukjinKwon opened a new pull request, #45283:
URL: https://github.com/apache/spark/pull/45283

   ### What changes were proposed in this pull request?
   
   This PR proposes to increase the timeout between between actions in `KafkaContinuousSourceSuite`.
   
   ### Why are the changes needed?
   
   In Mac OS build, those tests fail indeterministically, see
   - https://github.com/apache/spark/actions/runs/8054862135/job/22000404856
   - https://github.com/apache/spark/actions/runs/8040413156/job/21958488693
   - https://github.com/apache/spark/actions/runs/8032862212/job/21942732320
   - https://github.com/apache/spark/actions/runs/8024427919/job/21937366481
   
   `KafkaContinuousSourceSuite` is specifically slow in Mac OS. Kafka producers send the messages correctly, but the consumers can't get the messages for some reasons. You can't get the offsets for long time. This is not an issue in micro batch but I fail to identify the difference.
   
   I just decided to increase the timeout between actions for now. This is more just a workaround.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, test-only.
   
   ### How was this patch tested?
   
   Manually tested in my Mac.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47185][SS][TESTS] Increase timeout between actions in KafkaContinuousSourceSuite [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45283:
URL: https://github.com/apache/spark/pull/45283#issuecomment-1966836695

   Merged to master for Apache Spark 4.0.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47185][SS][TESTS] Increase timeout between actions in KafkaContinuousSourceSuite [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45283: [SPARK-47185][SS][TESTS] Increase timeout between actions in KafkaContinuousSourceSuite
URL: https://github.com/apache/spark/pull/45283


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47185][SS][TESTS] Increase timeout between actions in KafkaContinuousSourceSuite [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45283:
URL: https://github.com/apache/spark/pull/45283#issuecomment-1966227859

   cc @HeartSaVioR @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org