You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/13 06:29:04 UTC
[jira] [Commented] (CAMEL-11271) Support placeholders on attributes
of camelContext element
[ https://issues.apache.org/jira/browse/CAMEL-11271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009168#comment-16009168 ]
ASF GitHub Bot commented on CAMEL-11271:
----------------------------------------
GitHub user zregvart opened a pull request:
https://github.com/apache/camel/pull/1692
CAMEL-11271 Support placeholders on attributes of camelContext element
I'm not sure about the background, there could be a reason why attributes on `camelContext` don't get property placeholder support, so submitting for review. Thanks for taking a look 🥇
This adds logic to `afterPropertiesSet` to enumerate all fields of `CamelContextFactoryBean` and pass any `String` values to `CamelContext::resolvePropertyPlaceholders` for replacement.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zregvart/camel CAMEL-11271
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1692.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1692
----
commit e5384b4f63465a0603ba9971bf6a95ab20ed38a3
Author: Zoran Regvart <zr...@apache.org>
Date: 2017-05-13T06:24:57Z
CAMEL-11271 Support placeholders on attributes ...
...of camelContext element
This adds logic to `afterPropertiesSet` to enumerate all fields of
`CamelContextFactoryBean` and pass any `String` values
to `CamelContext::resolvePropertyPlaceholders` for replacement.
----
> Support placeholders on attributes of camelContext element
> ----------------------------------------------------------
>
> Key: CAMEL-11271
> URL: https://issues.apache.org/jira/browse/CAMEL-11271
> Project: Camel
> Issue Type: Improvement
> Components: camel-spring
> Reporter: Zoran Regvart
> Assignee: Zoran Regvart
>
> Property placeholders used in attributes of {{<camelContext>}} element don't get replaced when being set on the {{CamelContextFactoryBean}}.
> For example:
> {code:xml}
> <camelContext autoStartup="{{autoStartup}}" xmlns="http://camel.apache.org/schema/spring">
> ...
> </camelContext>
> {code}
> the {{autoStartup}} property of {{CamelContextFactoryBean}} will be set to the literal value of {{"{{autoStartup}}"}} and not replaced with property value with the key of {{autoStartup}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)