You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Boris Trishkin <no...@github.com> on 2019/01/11 12:43:29 UTC

[jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/452

-- Commit Summary --

  * Use State enum instead of String state in Domain classes

-- File Changes --

    M dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol/domain/Account.java (6)
    M dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol/domain/Disk.java (6)
    M dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol/domain/NIC.java (6)
    M dimensiondata/src/test/java/org/jclouds/dimensiondata/cloudcontrol/parse/ServerParseTest.java (4)
    M dimensiondata/src/test/java/org/jclouds/dimensiondata/cloudcontrol/parse/ServersParseTest.java (4)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/452.patch
https://github.com/jclouds/jclouds-labs/pull/452.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/452

Re: [jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

Posted by Ignasi Barrera <no...@github.com>.
nacx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/452#pullrequestreview-192058642

Re: [jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

Posted by Ignasi Barrera <no...@github.com>.
Closed #452.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/452#event-2071253686

Re: [jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

Posted by Ignasi Barrera <no...@github.com>.
Merged to master and 2.1.x. Thanks! See; https://github.com/apache/jclouds-labs

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/452#issuecomment-453941750

Re: [jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

Posted by Trevor Flanagan <no...@github.com>.
trevorflanagan commented on this pull request.

Nice one @btrishkin, this should mean that we no longer use String state anywhere.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/452#pullrequestreview-191645068