You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2015/03/23 09:45:20 UTC
Review Request 32389: OOZIE-2140 Audit Log should be shown in Oozie UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32389/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-2140
https://issues.apache.org/jira/browse/OOZIE-2140
Repository: oozie-git
Description
-------
OOZIE-2140 Audit Log should be shown in Oozie UI
Diffs
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 5feb360
client/src/main/java/org/apache/oozie/client/OozieClient.java 416d066
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4c75d2a
core/src/main/java/org/apache/oozie/BaseEngine.java 44074ea
core/src/main/java/org/apache/oozie/BundleEngine.java e191184
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1b21d87
core/src/main/java/org/apache/oozie/DagEngine.java faf2d64
core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 7970546
core/src/main/java/org/apache/oozie/service/XLogService.java c291fa8
core/src/main/java/org/apache/oozie/service/XLogStreamingService.java 9066c7a
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java b28a591
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java a581f8b
core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 4e9c224
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 3cb9168
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java d4564c6
core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 7100c98
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java d2aa02a
core/src/main/java/org/apache/oozie/util/XLogAuditFilter.java e69de29
core/src/main/java/org/apache/oozie/util/XLogFilter.java 5c0d1f3
core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java aedd35c
core/src/test/resources/test-no-dash-log4j.properties 2ff353e
docs/src/site/twiki/DG_CommandLineTool.twiki 762e2f1
docs/src/site/twiki/WebServicesAPI.twiki bf2bf50
webapp/src/main/webapp/oozie-console.js e07680f
Diff: https://reviews.apache.org/r/32389/diff/
Testing
-------
UTC and manul testing
$ oozie job -auditlog 0000000-150322000230582-oozie-puru-C -oozie http://localhost:11000/oozie
2015-03-22 00:04:35,494 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [start], PARAMETER [null], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
2015-03-22 00:05:13,823 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [suspend], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
2015-03-22 00:06:59,561 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [suspend], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
2015-03-22 23:22:20,012 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [suspend], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
2015-03-22 23:28:48,218 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [resume], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
$
Thanks,
Purshotam Shah
Re: Review Request 32389: OOZIE-2140 Audit Log should be shown in
Oozie UI
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32389/#review79584
-----------------------------------------------------------
Ship it!
Just minor variable name change. Please update that before checkin and also post updated patch to jira.
core/src/main/java/org/apache/oozie/service/XLogService.java
<https://reviews.apache.org/r/32389/#comment129052>
auditLogEnabled
core/src/main/java/org/apache/oozie/service/XLogService.java
<https://reviews.apache.org/r/32389/#comment129051>
isAuditLogEnabled
- Rohini Palaniswamy
On March 23, 2015, 8:45 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32389/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 8:45 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2140
> https://issues.apache.org/jira/browse/OOZIE-2140
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-2140 Audit Log should be shown in Oozie UI
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 5feb360
> client/src/main/java/org/apache/oozie/client/OozieClient.java 416d066
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4c75d2a
> core/src/main/java/org/apache/oozie/BaseEngine.java 44074ea
> core/src/main/java/org/apache/oozie/BundleEngine.java e191184
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1b21d87
> core/src/main/java/org/apache/oozie/DagEngine.java faf2d64
> core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 7970546
> core/src/main/java/org/apache/oozie/service/XLogService.java c291fa8
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java 9066c7a
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java b28a591
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java a581f8b
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 4e9c224
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 3cb9168
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java d4564c6
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 7100c98
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java d2aa02a
> core/src/main/java/org/apache/oozie/util/XLogAuditFilter.java e69de29
> core/src/main/java/org/apache/oozie/util/XLogFilter.java 5c0d1f3
> core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java aedd35c
> core/src/test/resources/test-no-dash-log4j.properties 2ff353e
> docs/src/site/twiki/DG_CommandLineTool.twiki 762e2f1
> docs/src/site/twiki/WebServicesAPI.twiki bf2bf50
> webapp/src/main/webapp/oozie-console.js e07680f
>
> Diff: https://reviews.apache.org/r/32389/diff/
>
>
> Testing
> -------
>
> UTC and manul testing
>
> $ oozie job -auditlog 0000000-150322000230582-oozie-puru-C -oozie http://localhost:11000/oozie
> 2015-03-22 00:04:35,494 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [start], PARAMETER [null], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> 2015-03-22 00:05:13,823 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [suspend], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> 2015-03-22 00:06:59,561 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [suspend], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> 2015-03-22 23:22:20,012 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [suspend], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> 2015-03-22 23:28:48,218 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [resume], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 32389: OOZIE-2140 Audit Log should be shown in
Oozie UI
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32389/#review78769
-----------------------------------------------------------
need auditlog test in TestZKXLogStreamingService for HA case, like errorlog (testStreamingWithMultipleOozieServers_errorLog)
core/src/main/java/org/apache/oozie/BaseEngine.java
<https://reviews.apache.org/r/32389/#comment127801>
Workflow/Coordinator Job Information --> Workflow/Coordinator/Bundle Audit log
(actualy the same goes to streamErrorLog javadoc)
core/src/main/java/org/apache/oozie/DagEngine.java
<https://reviews.apache.org/r/32389/#comment127802>
only starttime, endtime, lastmodifiedtime needed. no need to fetch entire job bean
core/src/main/java/org/apache/oozie/service/XLogService.java
<https://reviews.apache.org/r/32389/#comment127803>
just nitpick..
need to be public? other methods no modfier
- Ryota Egashira
On March 23, 2015, 8:45 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32389/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 8:45 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2140
> https://issues.apache.org/jira/browse/OOZIE-2140
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-2140 Audit Log should be shown in Oozie UI
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 5feb360
> client/src/main/java/org/apache/oozie/client/OozieClient.java 416d066
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4c75d2a
> core/src/main/java/org/apache/oozie/BaseEngine.java 44074ea
> core/src/main/java/org/apache/oozie/BundleEngine.java e191184
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1b21d87
> core/src/main/java/org/apache/oozie/DagEngine.java faf2d64
> core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 7970546
> core/src/main/java/org/apache/oozie/service/XLogService.java c291fa8
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java 9066c7a
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java b28a591
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java a581f8b
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 4e9c224
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 3cb9168
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java d4564c6
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 7100c98
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java d2aa02a
> core/src/main/java/org/apache/oozie/util/XLogAuditFilter.java e69de29
> core/src/main/java/org/apache/oozie/util/XLogFilter.java 5c0d1f3
> core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java aedd35c
> core/src/test/resources/test-no-dash-log4j.properties 2ff353e
> docs/src/site/twiki/DG_CommandLineTool.twiki 762e2f1
> docs/src/site/twiki/WebServicesAPI.twiki bf2bf50
> webapp/src/main/webapp/oozie-console.js e07680f
>
> Diff: https://reviews.apache.org/r/32389/diff/
>
>
> Testing
> -------
>
> UTC and manul testing
>
> $ oozie job -auditlog 0000000-150322000230582-oozie-puru-C -oozie http://localhost:11000/oozie
> 2015-03-22 00:04:35,494 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [start], PARAMETER [null], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> 2015-03-22 00:05:13,823 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [suspend], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> 2015-03-22 00:06:59,561 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [suspend], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> 2015-03-22 23:22:20,012 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [suspend], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> 2015-03-22 23:28:48,218 INFO oozieaudit:520 - IP [127.0.0.1], USER [purushah], GROUP [null], APP [-], JOBID [0000000-150322000230582-oozie-puru-C], OPERATION [resume], PARAMETER [0000000-150322000230582-oozie-puru-C], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null]
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>