You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/11/03 06:00:19 UTC

[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

turboFei opened a new pull request, #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei closed pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level 
URL: https://github.com/apache/incubator-kyuubi/pull/3753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1301869070

   retrying https://github.com/apache/incubator-kyuubi/actions/runs/3384044997 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] wForget commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
wForget commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1302030349

   > cc @cfmcgrady @wForget
   > 
   > I do not know why indeed.
   
   I'm also confused about this, but this fix looks good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1302055025

   > Is it possible that serviceNode: PersistentNode is automatically recreate after being deleted?
   
   Not sure, but it did can be deleted finally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1302377157

   ```
   - JpsApplicationOperation with jstat *** FAILED ***
     null equaled null (JpsApplicationOperationSuite.scala:56)
     S0     S1     E      O      M     CCS    YGC     YGCT    FGC    FGCT    CGC    CGCT     GCT   
     0.00 100.00  92.04  78.54  96.79  87.17     45    0.786     0    0.000    22    0.470    1.255
     0.00 100.00  93.81  78.54  96.79  87.17     45    0.786     0    0.000    22    0.470    1.255
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1302017865

   Passed again
   
   ![image](https://user-images.githubusercontent.com/6757692/199718574-8ee07bde-7bf3-4601-bf76-be3f17c7ac02.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1302019158

   cc @cfmcgrady  @wForget 
   
   I do not know why indeed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] wForget commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
wForget commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1302043566

   > cc @cfmcgrady @wForget
   > 
   > I do not know why indeed.
   
   Is it possible that `serviceNode: PersistentNode` is automatically recreate after being deleted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1301868268

   UT passed one time, try again
   
   <img width="954" alt="image" src="https://user-images.githubusercontent.com/6757692/199692658-ece52265-868e-41f2-acd8-9083281daade.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1304438219

   thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3753: Fix flaky test - AdminResourceSuite: delete engine - user share level

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3753:
URL: https://github.com/apache/incubator-kyuubi/pull/3753#issuecomment-1302018700

   try again 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org