[jira] [Commented] (FLINK-7624) Add kafka-topic for "KafkaProducer" metrics

["Tzu-Li (Gordon) Tai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166204#comment-16166204 ] 

Tzu-Li (Gordon) Tai commented on FLINK-7624:
--------------------------------------------

I think changing an existing metric name would in a sense be breaking "public API". We could think of adding a new set of metrics for this that separates the metrics per-topic, while still keeping the original metrics.

> Add kafka-topic for "KafkaProducer" metrics
> -------------------------------------------
>
>                 Key: FLINK-7624
>                 URL: https://issues.apache.org/jira/browse/FLINK-7624
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>            Reporter: Hai Zhou
>            Assignee: Hai Zhou
>             Fix For: 1.4.0
>
>
> Currently, metric in "KafkaProducer" MetricGroup, Such as:
> {code:java}
> localhost.taskmanager.dc4092a96ea4e54ecdbd13b9a5c209b2.Flink Streaming Job.Sink--MTKafkaProducer08.0.KafkaProducer.record-queue-time-avg
> {code}
> The metric name in the "KafkaProducer" group does not have a kafka-topic name part,  if the job writes data to two different kafka sinks, these metrics will not distinguish.
> I wish that modify the above metric name as follows:
> {code:java}
> localhost.taskmanager.dc4092a96ea4e54ecdbd13b9a5c209b2.Flink Streaming Job.Sink--MTKafkaProducer08.0.KafkaProducer.<kafka topic>.record-queue-time-avg
> {code}
> Best,
> Hai Zhou



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)