[GitHub] [iceberg] szehon-ho edited a comment on pull request #2608: Core : Repair manifests

[GitBox <gi...@apache.org>]

szehon-ho edited a comment on pull request #2608:
URL: https://github.com/apache/iceberg/pull/2608#issuecomment-845015249


   Great to see you back @rdblue  :)
   
   Yes, after this first implementation, I see some advantages of having dedicated RepairManifestAction.  RewriteManifestAction is compaction-oriented, and in so by design it cannot run across two separate partitionSpecs, whereas RepairManifests should be able to do so as it would not combine manifest files.  
   
   And yes in general, I see the two can be conceptually different like you said.  I can spend some time to look at making this separate action, and refactor common code to the base class.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org