You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/27 00:34:20 UTC

[GitHub] [incubator-superset] ericandrewmeadows opened a new pull request #8117: Fix to werkzeug proxy; expose additional configuration items

ericandrewmeadows opened a new pull request #8117: Fix to werkzeug proxy; expose additional configuration items
URL: https://github.com/apache/incubator-superset/pull/8117
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Custom Security Manager appeared to be broken when behind an AWS ALB, but when I dug further, the Werkzeug version was bumped.  This caused an invalid configuration for the proxy in that the host was not passed on.  Because of this, along with the change of the library path, and the inclusion of the additional library bump in accordance with https://github.com/apache/airflow/pull/5571, I have validated that the regression that prevented CSM from working in v0.33.0rc1 -> v0.34.0rc [1 & 2] has been resolved.
   
   ### TEST PLAN
   I deployed internally the fix, and validated that the port is not being returned in the header for the destination after hitting the root IP of the Superset instance.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
     - Fixes #8062 
     - Fixes #8110 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org