You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/09/26 13:33:40 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #43130: [WIP][SQL] Remove the SQL config `spark.sql.hive.verifyPartitionPath`
MaxGekk opened a new pull request, #43130:
URL: https://github.com/apache/spark/pull/43130
### What changes were proposed in this pull request?
In the PR, I propose to remove already deprecated SQL config `spark.sql.hive.verifyPartitionPath`, and the code under the config.
### Why are the changes needed?
To improve code maintainability by remove unused code.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By running the modified test suite:
```
$ build/sbt "test:testOnly *SQLConfSuite"
$ build/sbt "test:testOnly *QueryPartitionSuite"
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #43130: [SPARK-45340][SQL] Remove the SQL config `spark.sql.hive.verifyPartitionPath`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #43130: [SPARK-45340][SQL] Remove the SQL config `spark.sql.hive.verifyPartitionPath`
URL: https://github.com/apache/spark/pull/43130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #43130: [SPARK-45340][SQL] Remove the SQL config `spark.sql.hive.verifyPartitionPath`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #43130:
URL: https://github.com/apache/spark/pull/43130#issuecomment-1736726654
Merging to master. Thank you, @cloud-fan and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #43130: [SPARK-45340][SQL] Remove the SQL config `spark.sql.hive.verifyPartitionPath`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #43130:
URL: https://github.com/apache/spark/pull/43130#discussion_r1337356266
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4552,7 +4542,9 @@ object SQLConf {
RemovedConfig("spark.sql.ansi.strictIndexOperator", "3.4.0", "true",
"This was an internal configuration. It is not needed anymore since Spark SQL always " +
"returns null when getting a map value with a non-existing key. See SPARK-40066 " +
- "for more details.")
+ "for more details."),
+ RemovedConfig("spark.sql.hive.verifyPartitionPath", "4.0.0", "false",
+ s"This config was replaced by '${SPARK_IGNORE_MISSING_FILES.key}'.")
Review Comment:
rebased and changed the config name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #43130: [SPARK-45340][SQL] Remove the SQL config `spark.sql.hive.verifyPartitionPath`
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #43130:
URL: https://github.com/apache/spark/pull/43130#discussion_r1337239869
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4552,7 +4542,9 @@ object SQLConf {
RemovedConfig("spark.sql.ansi.strictIndexOperator", "3.4.0", "true",
"This was an internal configuration. It is not needed anymore since Spark SQL always " +
"returns null when getting a map value with a non-existing key. See SPARK-40066 " +
- "for more details.")
+ "for more details."),
+ RemovedConfig("spark.sql.hive.verifyPartitionPath", "4.0.0", "false",
+ s"This config was replaced by '${SPARK_IGNORE_MISSING_FILES.key}'.")
Review Comment:
shall we use the sql config since https://github.com/apache/spark/pull/43097 will be merged soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #43130: [SPARK-45340][SQL] Remove the SQL config `spark.sql.hive.verifyPartitionPath`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #43130:
URL: https://github.com/apache/spark/pull/43130#discussion_r1337286404
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4552,7 +4542,9 @@ object SQLConf {
RemovedConfig("spark.sql.ansi.strictIndexOperator", "3.4.0", "true",
"This was an internal configuration. It is not needed anymore since Spark SQL always " +
"returns null when getting a map value with a non-existing key. See SPARK-40066 " +
- "for more details.")
+ "for more details."),
+ RemovedConfig("spark.sql.hive.verifyPartitionPath", "4.0.0", "false",
+ s"This config was replaced by '${SPARK_IGNORE_MISSING_FILES.key}'.")
Review Comment:
Yep, I plan to merge this PR https://github.com/apache/spark/pull/43097 first of all, and then rebase this PR on those changes by modifying the test and this place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org