You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/12 13:31:02 UTC
[GitHub] [flink-table-store] LadyForest opened a new pull request, #211: [FLINK-28465] commit.force-compact should always be true under batch mode
LadyForest opened a new pull request, #211:
URL: https://github.com/apache/flink-table-store/pull/211
Under batch mode, the framework should always synchronize the compaction result before committing, and it is annoying to let users set this value to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #211: [FLINK-28465] commit.force-compact should always be true under batch mode
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #211:
URL: https://github.com/apache/flink-table-store/pull/211#discussion_r919616462
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/AbstractTableStoreFactory.java:
##########
@@ -132,9 +133,14 @@ private static void validateFileStoreContinuous(Configuration options) {
}
static FileStoreTable buildFileStoreTable(DynamicTableFactory.Context context) {
- FileStoreTable table =
- FileStoreTableFactory.create(
- Configuration.fromMap(context.getCatalogTable().getOptions()));
+ boolean batch =
+ context.getConfiguration().get(ExecutionOptions.RUNTIME_MODE)
+ == RuntimeExecutionMode.BATCH;
+ Map<String, String> options = new HashMap<>(context.getCatalogTable().getOptions());
+ if (batch) {
+ options.put(CoreOptions.COMMIT_FORCE_COMPACT.key(), String.valueOf(true));
Review Comment:
Does the config option `COMMIT_FORCE_COMPACT` need to explain in the description that the default value is true in BATCH mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest closed pull request #211: [FLINK-28465] commit.force-compact should always be true under batch mode
Posted by GitBox <gi...@apache.org>.
LadyForest closed pull request #211: [FLINK-28465] commit.force-compact should always be true under batch mode
URL: https://github.com/apache/flink-table-store/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #211: [FLINK-28465] Wait compaction finished in endInput
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #211:
URL: https://github.com/apache/flink-table-store/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #211: [FLINK-28465] commit.force-compact should always be true under batch mode
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #211:
URL: https://github.com/apache/flink-table-store/pull/211#discussion_r919615647
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/AbstractTableStoreFactory.java:
##########
@@ -132,9 +133,14 @@ private static void validateFileStoreContinuous(Configuration options) {
}
static FileStoreTable buildFileStoreTable(DynamicTableFactory.Context context) {
- FileStoreTable table =
- FileStoreTableFactory.create(
- Configuration.fromMap(context.getCatalogTable().getOptions()));
+ boolean batch =
+ context.getConfiguration().get(ExecutionOptions.RUNTIME_MODE)
+ == RuntimeExecutionMode.BATCH;
+ Map<String, String> options = new HashMap<>(context.getCatalogTable().getOptions());
Review Comment:
```suggestion
Configuration configuration = Configuration.fromMap(context.getCatalogTable().getOptions());
configuration.setBoolean(CoreOptions.COMMIT_FORCE_COMPACT, batch);
FileStoreTable table = FileStoreTableFactory.create(configuration);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org