[GitHub] stevedlawrence commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.
URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251393696
 
 

 ##########
 File path: daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLITunables2.scala
 ##########
 @@ -34,13 +34,13 @@ class TestCLITunables2 {
 
     try {
       // note: 2>&1 is shell-speak for "connect stderr into stdout"
-      val cmd = String.format("""echo "a,b" | %s parse -s %s -TsuppressSchemaDefinitionWarnings=all 2>&1""", Util.binPath, testSchemaFile)
+      val cmd = String.format("""echo a,b| %s parse -s %s -TsuppressSchemaDefinitionWarnings=all 2>&1""", Util.binPath, testSchemaFile)
 
 Review comment:
   The new ``Util.echoN`` function is actually only needed when the ``-n`` flag is used. The echo command behaves exactly the same on linux in windows if the following conditions are met:
   
   1. No flags are provided (i.e. ``-n``)
   1. No quotes are needed
   1. No spaces exists at the end of the echo string before the pipe
   
   If these are all true, then the only difference between windows and linux echo is CRLF vs LF, which the schemes in most of these tests handle with ``%NL;``. In this particular test, we needed to remove the quotes and the space before the pipe to make it work on linux and windows, but the schema is fine with the newline differences. In cases where the ``-n`` flag was used for linux, the new ``Util.echoN`` function was created, which creates the right command to echo without a newline at the end based on the operating system. So only tests that do not expect a ``%NL;`` need use use the new function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services