You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/02/23 20:50:33 UTC
Re: Review Request 43893: Made sure that spawned processes terminated
before leaving test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43893/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 8:50 p.m.)
Review request for mesos and Joseph Wu.
Changes
-------
Offline comments from Joseph.
Summary (updated)
-----------------
Made sure that spawned processes terminated before leaving test.
Bugs: MESOS-4747
https://issues.apache.org/jira/browse/MESOS-4747
Repository: mesos
Description (updated)
-------
Made sure that spawned processes terminated before leaving tests.
Diffs (updated)
-----
src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f
Diff: https://reviews.apache.org/r/43893/diff/
Testing
-------
make check
make check GTEST_FILTER=ContainerLoggerTest.MesosContainerizerRecover
Thanks,
Benjamin Bannier
Re: Review Request 43893: Made sure that spawned processes terminated
before leaving test.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43893/#review120383
-----------------------------------------------------------
Ship it!
I feel there are a bunch of tests around that do not verify certain events actually happen before continuing. We should probably go and look into that.
- Alexander Rojas
On Feb. 23, 2016, 8:50 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43893/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 8:50 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-4747
> https://issues.apache.org/jira/browse/MESOS-4747
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made sure that spawned processes terminated before leaving tests.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f
>
> Diff: https://reviews.apache.org/r/43893/diff/
>
>
> Testing
> -------
>
> make check
> make check GTEST_FILTER=ContainerLoggerTest.MesosContainerizerRecover
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 43893: Made sure that spawned processes terminated
before leaving test.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43893/#review120466
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 23, 2016, 11:50 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43893/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 11:50 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-4747
> https://issues.apache.org/jira/browse/MESOS-4747
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made sure that spawned processes terminated before leaving tests.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f
>
> Diff: https://reviews.apache.org/r/43893/diff/
>
>
> Testing
> -------
>
> make check
> make check GTEST_FILTER=ContainerLoggerTest.MesosContainerizerRecover
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 43893: Made sure that spawned processes terminated
before leaving test.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43893/#review120370
-----------------------------------------------------------
Ship it!
LGTM!
- Joseph Wu
On Feb. 23, 2016, 11:50 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43893/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 11:50 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-4747
> https://issues.apache.org/jira/browse/MESOS-4747
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made sure that spawned processes terminated before leaving tests.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f
>
> Diff: https://reviews.apache.org/r/43893/diff/
>
>
> Testing
> -------
>
> make check
> make check GTEST_FILTER=ContainerLoggerTest.MesosContainerizerRecover
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 43893: Made sure that spawned processes terminated
before leaving test.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43893/#review120438
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43893]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 23, 2016, 7:50 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43893/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 7:50 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-4747
> https://issues.apache.org/jira/browse/MESOS-4747
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made sure that spawned processes terminated before leaving tests.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f
>
> Diff: https://reviews.apache.org/r/43893/diff/
>
>
> Testing
> -------
>
> make check
> make check GTEST_FILTER=ContainerLoggerTest.MesosContainerizerRecover
>
>
> Thanks,
>
> Benjamin Bannier
>
>