[GitHub] [cassandra] josh-mckenzie commented on a change in pull request #1520: CASSANDRA-17478

[GitBox <gi...@apache.org>]

josh-mckenzie commented on a change in pull request #1520:
URL: https://github.com/apache/cassandra/pull/1520#discussion_r836543167



##########
File path: src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java
##########
@@ -297,7 +298,9 @@ else if (replication != null)
                        .forEach(dc -> options.putIfAbsent(dc, defaultReplicas.toParseableString()));
         }
 
-        options.values().removeAll(Collections.singleton("0"));
+        // We do not filter out "0" due to the AUTH_KEYSPACE validation in validateExpectedOptions.
+        // The previousOptions are unavailable to that check so it is not possible to verify that all valid
+        // datacenters have an explicit configuration (even if it is 0).

Review comment:
       You don't think the comment is needed, the filtering out of "0", the removal of filtering out of "0" here...?
   
   Or something else entirely? ;)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org