[GitHub] [airflow] potiuk commented on a diff in pull request #29908: Fix empty paths in Vault secrets backend

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #29908:
URL: https://github.com/apache/airflow/pull/29908#discussion_r1125563374


##########
airflow/providers/hashicorp/secrets/vault.py:
##########
@@ -175,8 +175,10 @@ def get_response(self, conn_id: str) -> dict | None:
         mount_point, conn_key = self._parse_path(conn_id)
         if self.connections_path is None or conn_key is None:
             return None
-
-        secret_path = self.build_path(self.connections_path, conn_key)
+        if self.connections_path == "":
+            secret_path = conn_key

Review Comment:
   I believe this is because None can really only happens if there is no "/"  in path and mount_point is not defined. Which is a basic requirement for vault - any time you expect something from vault you need to specify the mount_point and "/" is a way how it can be specified directly in the path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org