You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/08/26 18:23:08 UTC
[GitHub] [fineract] Cadreia opened a new pull request #1841: Net Disbursal Amount Feature (FINERACT-1321)
Cadreia opened a new pull request #1841:
URL: https://github.com/apache/fineract/pull/1841
## Description
Implements the net disbursal amount feature.
Details of this issue can be found on this [Apache Fineract JIRA ticket](https://issues.apache.org/jira/browse/FINERACT-1321).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola edited a comment on pull request #1841: Net Disbursal Amount Feature (FINERACT-1321)
Posted by GitBox <gi...@apache.org>.
ptuomola edited a comment on pull request #1841:
URL: https://github.com/apache/fineract/pull/1841#issuecomment-923985096
Hi @Cadreia - code looks all good, but looks like the build is failing and there are some merge conflicts. Could you resolve these, squash the commits, put the JIRA issue number into the commit message please, and we can then merge this in? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Cadreia commented on pull request #1841: Net Disbursal Amount Feature (FINERACT-1321)
Posted by GitBox <gi...@apache.org>.
Cadreia commented on pull request #1841:
URL: https://github.com/apache/fineract/pull/1841#issuecomment-926003961
Conflicts have been resolved and build passes now. Please review. Link to the PR for the corresponding UI change is in the description above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1841: Net Disbursal Amount Feature (FINERACT-1321)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1841:
URL: https://github.com/apache/fineract/pull/1841#issuecomment-923985096
Hi @Cadreia - code looks all good, but looks like the build is failing and there are some merge conflicts. Could you resolve these and squash the commits, and we can then merge this in? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1841: Net Disbursal Amount Feature (FINERACT-1321)
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1841:
URL: https://github.com/apache/fineract/pull/1841#issuecomment-914171900
This looks interesting. Thanks for the PR @Cadreia , Can you update the PR to fix the merge conflicts? Sorry for the delay.
@francisguchie and @bharathc27 , Please can you help us test functionally test this? You can ask all the relevant questions here.
@Cadreia Does this change have or need a corresponding UI change or PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror merged pull request #1841: Net Disbursal Amount Feature (FINERACT-1321)
Posted by GitBox <gi...@apache.org>.
xurror merged pull request #1841:
URL: https://github.com/apache/fineract/pull/1841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org