You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "gfphoenix78 (via GitHub)" <gi...@apache.org> on 2025/07/10 09:41:19 UTC
[PR] PAX: Use const reference to avoid constructor/destructor of shared pointer [cloudberry]
gfphoenix78 opened a new pull request, #1221:
URL: https://github.com/apache/cloudberry/pull/1221
Accessing the visibility bitmap of a column is temporary. Frequently building the shared pointer of the bitmap and destroy it will hurt performance.
Note: The returned left reference should not hold long time, its lifetime must be shorter than the corresponding column.
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] PAX: Use const reference to avoid constructor/destructor of shared pointer [cloudberry]
Posted by "gfphoenix78 (via GitHub)" <gi...@apache.org>.
gfphoenix78 commented on PR #1221:
URL: https://github.com/apache/cloudberry/pull/1221#issuecomment-3056614242
The flame graph shows high cost of destructor of shared pointers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] PAX: Use const reference to avoid constructor/destructor of shared pointer [cloudberry]
Posted by "gfphoenix78 (via GitHub)" <gi...@apache.org>.
gfphoenix78 commented on PR #1221:
URL: https://github.com/apache/cloudberry/pull/1221#issuecomment-3060772234
> > 
> > The flame graph shows high cost of destructor of shared pointers.
>
> do we have the flame graph after this PR?
>
> And i remember @gongxun0928 has a PR that modified the `shared_ptr`, but hasn't submitted it to the cloudberrydb yet?
Yes, the cloudberry doesn't have the patch by @gongxun0928 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] PAX: Use const reference to avoid constructor/destructor of shared pointer [cloudberry]
Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it merged PR #1221:
URL: https://github.com/apache/cloudberry/pull/1221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] PAX: Use const reference to avoid constructor/destructor of shared pointer [cloudberry]
Posted by "jiaqizho (via GitHub)" <gi...@apache.org>.
jiaqizho commented on PR #1221:
URL: https://github.com/apache/cloudberry/pull/1221#issuecomment-3059888314
> 
>
> The flame graph shows high cost of destructor of shared pointers.
do we have the flame graph after this PR?
And i remember @gongxun0928 has a PR that modified the `shared_ptr`, but hasn't submitted it to the cloudberrydb yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] PAX: Use const reference to avoid constructor/destructor of shared pointer [cloudberry]
Posted by "gfphoenix78 (via GitHub)" <gi...@apache.org>.
gfphoenix78 commented on PR #1221:
URL: https://github.com/apache/cloudberry/pull/1221#issuecomment-3060769224
> > 
> > The flame graph shows high cost of destructor of shared pointers.
>
> do we have the flame graph after this PR?
>
> And i remember @gongxun0928 has a PR that modified the `shared_ptr`, but hasn't submitted it to the cloudberrydb yet?
Sure, the flame graph after applying the patch is below:
The cost of destructing shared pointer is eliminated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org