You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Ankit Singhal (Jira)" <ji...@apache.org> on 2019/10/24 23:18:00 UTC
[jira] [Resolved] (HBASE-20910) Fix dev-support/submit-patch.py by
opening file with 'b' mode
[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ankit Singhal resolved HBASE-20910.
-----------------------------------
Fix Version/s: 3.0.0
Resolution: Fixed
> Fix dev-support/submit-patch.py by opening file with 'b' mode
> -------------------------------------------------------------
>
> Key: HBASE-20910
> URL: https://issues.apache.org/jira/browse/HBASE-20910
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20910.patch, HBASE-20910_v1.patch
>
>
> {code:python}
> hbase$ python3.6 dev-support/submit-patch.py
> INFO:submit-patch: Active branch: master
> INFO:submit-patch: Using tracking branch as base branch
> INFO:submit-patch: Base branch: origin/master
> INFO:submit-patch: Patch directory: /Users/asinghal/patches
> INFO:submit-patch: Patch name: master.patch
> Traceback (most recent call last):
> File "dev-support/submit-patch.py", line 253, in <module>
> f.write(diff.encode('utf8'))
> TypeError: write() argument must be str, not bytes
> {code}
> [~tedyu@apache.org], FYI
--
This message was sent by Atlassian Jira
(v8.3.4#803005)