You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2025/01/23 01:28:12 UTC
[kudu-CR] [WIP] Upgrade Java dependencies
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22374
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
2 files changed, 34 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/1
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#18).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
mockitoCore library dependency is added to the upgraded hadoop version[1]
Changes in shadow.gradle:
Excluding classes with Java21 as Gradle 7 doesn't recognize them.
Excluding Java9 version specific classes(module-info.class) as we compile with
Java8 and don't need them anyway.
Excluding bouncycastle due to [2]
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
[2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-client-modules/hadoop-client-runtime/pom.xml#L156-L157
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-test-utils/build.gradle
6 files changed, 30 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/18
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 14: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1115/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 15:41:39 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#7).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
2 files changed, 26 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/7
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 6: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1047/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Feb 2025 21:45:52 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 17: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG@19
PS17, Line 19: 3.4.1
this dependency is 3.4.0 in the dependencies.gradle file
http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG@50
PS17, Line 50: erorr
typo: error
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 07:25:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 14: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1114/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 08:55:54 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 17:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1122/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 07:13:51 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 19: Verified+1
Thanks for taking a look Alexey. The issue in PS-18 is fixed. Kindly take a look.
Unrelated Failure.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Mar 2025 23:16:10 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 22:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: shadowJar {
: dependencies {
: exclude(dependency("log4j::.*"))
: exclude(dependency("org.apache.hadoop::.*"))
: exclude(dependency("org.apache.hive::.*"))
: exclude(dependency("org.apache.hbase::.*"))
: exclude(dependency("org.apache.hbase.thirdparty::.*"))
: exclude(dependency("junit::.*"))
: exclude(dependency("javax.servlet.jsp::.*"))
: exclude(dependency("javax.jdo::.*"))
:
> > Q. Why is the test failing with hadoop-common:3.4.1 and not with hadoop-c
It was not failing in hadoop-common:3.3.1 as the needed class(BatchListingOperations) was present during the test runtime. It was present as a transitive dependency while it was not present when using version 3.4.1, hence the error message:
Caused by: java.lang.NoClassDefFoundError: org/apache/hadoop/fs/BatchListingOperations
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 22
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 17:28:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#6).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
2 files changed, 27 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/6
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22374/20//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22374/20//COMMIT_MSG@44
PS20, Line 44: Changes in shadow.gradle:
: Excluding classes with Java21 as Gradle 7 doesn't recognize them.
: Excluding Java9 version specific classes(module-info.class) as we compile with
: Java8 and don't need them anyway.
: Excluding bouncycastle due to [2]
:
: [1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
: [2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a0
Could you please in-line this information into the shadow.gradle file itself? That way it's much easier to track and comprehend the reasoning of having particular rules there. It should help in future when updating the shadowing rules, when necessary.
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
This looks a bit strange. Should we then remove this and the two packages that were added as dependencies at lines 26-27 (libs.hadoopCommon and libs.hadoopMRClientCommon)? At least, I was able to successfully run './gradlew assemble' locally after removing those.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Mar 2025 19:03:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 26: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1244/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 26
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 21:21:30 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 8: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1062/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 03:53:30 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 10: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1070/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 20:24:10 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 18:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1158/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Mar 2025 00:27:05 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 21: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1225/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Mar 2025 23:00:29 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 22:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1232/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 22
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 06:17:40 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1174/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 02:18:04 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 23: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22374/23/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/23/java/gradle/shadow.gradle@51
PS23, Line 51: // Excluding classes with Java21 as Gradle 7 doesn't recognize them and
: // Java9 version specific classes(module-info.class) as we compile with
: // Java8 and don't need them anyway.
I guess the current list of versions to exclude was found by trial-and-error, right? The explanation doesn't bode quite well with the two lines below and opens a few questions regarding MR JARs.
1) What about other versions of Java that Gradle 7.6 doesn't support per https://docs.gradle.org/8.8-rc-1/userguide/compatibility.html? E.g., Java20, Java22, and newer -- does it makes sense to exclude those as well or we will just wait for the next time the compilation breaks, and add an extra exclusion when we hit it here?
2) AFAIK, the project can be officially compiled with Java11. Just curious: when trying to compile with Java11 target release, is it necessary to exclude "META-INF/versions/9/**" as well?
3) If trying to follow the logic of excluding all version-specific stuff with the release version higher than the target release version when compiling the project, does it make sense to exclude version-specific stuff of all versions onward starting version 9 if compiling with Java8?
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: shadowJar {
: dependencies {
: exclude(dependency("log4j::.*"))
: exclude(dependency("org.apache.hadoop::.*"))
: exclude(dependency("org.apache.hive::.*"))
: exclude(dependency("org.apache.hbase::.*"))
: exclude(dependency("org.apache.hbase.thirdparty::.*"))
: exclude(dependency("junit::.*"))
: exclude(dependency("javax.servlet.jsp::.*"))
: exclude(dependency("javax.jdo::.*"))
:
> It was not failing in hadoop-common:3.3.1 as the needed class(BatchListingO
Thanks for the update.
OK, I guess it looked quite misleading to me since in the question and the original explanation the emphasis was on the version rather than the classpath details.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 23
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:38:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#3).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
2 files changed, 32 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/3
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/959/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 Jan 2025 17:59:04 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
> It seems 'testImplementation libs.hadoopMRClientCommon' is needed for tests
The tests are not happy with that change. Failing with:
java.lang.NoClassDefFoundError: org/apache/hadoop/mapred/JobConf
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
> After looking at this a bit more, I realized that migrating these transitiv
This looks like a cleaner approach. Let me do some reading and get back to you.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Mar 2025 03:39:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
> ... However this might be a big undertaking ...
Right, that's what I wasn't able to estimate since I hadn't done anything like that before. Zoltan, if you definitely know that's a lot of work, then we should go forward with an alternative approach for 1.18.0 -- I agree.
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Mar 2025 03:29:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 11: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1087/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2025 22:12:19 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#5).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
2 files changed, 29 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/5
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1035/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Feb 2025 01:11:15 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1026/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 Feb 2025 02:48:54 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 26: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 26
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Apr 2025 12:16:58 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 17:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG@19
PS17, Line 19: 3.4.1
> this dependency is 3.4.0 in the dependencies.gradle file
It is now updated to 3.4.1
http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG@44
PS17, Line 44: so this file
: could be used in future when we compile with JDK 9
> I'm not sure the placement of that file makes sense at all: the module-info
Answered in the other comment in the specific file.
http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG@50
PS17, Line 50: erorr
> typo: error
Done
http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl
File build-support/verify_jars.pl:
http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl@62
PS17, Line 62: META-INF/versions/9/module-info.class
> I ran the verify_jars.py after building the java project with JDK8, however
@Alexey
This is not a bug but expected behavior as per the docs. It is to be placed under META_INF/versions/<version_number>/ in case of a multi release jar. If not it is to be placed in the root directory:
https://docs.oracle.com/en/java/javase/16/docs/specs/jar/jar.html#multi-release-jar-files
I think it makes sense to exclude this file while building the jar by specifying in build.gradle file.
@Zoltan:
Strange that I did not find that issue when I previously posted this patch in my environment and also in the buidl environments. Nevertheless, this seems to be coming form upgrading Hive 3.1.2->3.1.3 which doesn't address any CVEs so we can skip it for now and upgrade to Hive 4 directly when we are ready.
http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle@26
PS17, Line 26: testImplementation
> +1 on Alexey's question, the original compiles just fine.
Hive 3.1.3 seems to have brought in this dependency. It is not clear from the changelist[1], but the kudu-hive tests are failing with the below error:
Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.fs.BatchListingOperations
We can skip this for now and upgrade directly to Hive 4 as there are no known CVEs being addressed by this. Let me know if you think otherwise.
[1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12346277&styleName=Html&projectId=12310843
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Mar 2025 00:26:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#11).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M build-support/verify_jars.pl
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
3 files changed, 27 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/11
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 10:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1070/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 20:20:21 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 26:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1244/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 26
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 20:13:15 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 25:
I cherry picked my Spark3.5 update over this and didn't realise that by pushing I will rebase this change as well. Didn't want to meddle, sorry Abhishek!
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 25
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 09:20:54 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/949/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Jan 2025 01:28:17 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/949/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Jan 2025 01:45:35 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 7:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1059/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 00:39:44 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 7:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1059/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 00:39:22 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#16).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- hive - 3.1.2 -> 3.1.3
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
verify_jars.pl has been updated to include module-info.class from
micrometer library. Currently we only build on JDK 8 so this file
could be used in future when we compile with JDK 9.
mockitoCore library dependency is added to the upgraded hadoop version[1]
hadoopCommon library dependency is required for hive tests to run without
which we end up with erorr as below:
Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.fs.BatchListingOperations
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M build-support/verify_jars.pl
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
5 files changed, 29 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/16
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 16
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 17:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG@44
PS17, Line 44: so this file
: could be used in future when we compile with JDK 9
I'm not sure the placement of that file makes sense at all: the module-info.class must be in the root of a JAR, not under META-INF/versions/9.
Also, why other 9-versioned files in that MRJAR file aren't triggering any checks then? I'm not sure I understand what's going on. Could you shed some light on this, please?
http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl
File build-support/verify_jars.pl:
http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl@62
PS17, Line 62: META-INF/versions/9/module-info.class
Isn't this a fluke/bug? Why module-info.class is under the versioned MRJAR section, not just under the root of the JAR file structure?
Did you check other published versions of micrometer JAR -- do they have the same strange placement of module-info.class due to some bug in the javac that created the JAR or that's something else behind?
http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle@26
PS17, Line 26: testImplementation
Are you sure that's not needed in regular (i.e. not just test) runtime?
In other words, I'd have no question on this change if in prior version that was testCompileOnly and now you change it into 'testImplemenation' that adds it into the test run-time paths in addition to having it in compile-time path. But changing 'compileOnly' --> 'testImplementation' is a bit strange.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 20:26:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
> This looks a bit strange. Should we then remove this and the two packages
It seems 'testImplementation libs.hadoopMRClientCommon' is needed for tests, but I guess we could try to remove 'compileOnly libs.hadoopCommon' and this extra wart on resolution strategy.
What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Mar 2025 19:19:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 19:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1162/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Mar 2025 17:22:43 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
> The tests are not happy with that change. Failing with:
java.lang.NoClassDefFoundError: org/apache/hadoop/mapred/JobConf
Yep, I got the same result.
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
> This looks like a cleaner approach. Let me do some reading and get back to you.
It would be great to clarify on this. What I don't like about using resolutionStrategy, is that it looks like a hack, at least at this point.
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Mar 2025 04:21:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 25: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1242/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 25
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 10:17:37 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#24).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
mockitoCore library dependency is added to the upgraded hadoop version[1]
Changes in shadow.gradle:
Excluding classes aove Java19 as Gradle 7.6 doesn't recognize them.
Excluding Java9 version Multi-Release JAR specific classes(module-info.class).
Excluding bouncycastle due to [2].
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
[2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-client-modules/hadoop-client-runtime/pom.xml#L156-L157
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-test-utils/build.gradle
6 files changed, 37 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/24
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 24
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 9:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1066/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 07:55:14 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/959/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 Jan 2025 18:09:52 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 13:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1110/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 13
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 22:14:25 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 5:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1035/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 Feb 2025 23:57:48 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 17: -Code-Review
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl
File build-support/verify_jars.pl:
http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl@62
PS17, Line 62: META-INF/versions/9/module-info.class
> Isn't this a fluke/bug? Why module-info.class is under the versioned MRJAR
I ran the verify_jars.py after building the java project with JDK8, however it still throws errors[0], so this is insufficient. Instead of adding this here, maybe try excluding the Java9 versioned classes altogether from the kudu-hive dependencies?
[0]:
$>: ../build-support/verify_jars.pl .
Checking jars in directory: /Users/zchovan/CLionProjects/kudu/java
> ./kudu-backup/build/libs/kudu-backup3_2.12-1.18.0-SNAPSHOT.jar
> ./kudu-client/build/libs/kudu-client-1.18.0-SNAPSHOT.jar
> ./kudu-proto/build/libs/kudu-proto-1.18.0-SNAPSHOT.jar
> ./kudu-spark-tools/build/libs/kudu-spark3-tools_2.12-1.18.0-SNAPSHOT.jar
> ./kudu-hive/build/libs/kudu-hive-1.18.0-SNAPSHOT.jar
NON_KUDU avro/shaded/com/google/common/collect/package-info.class
NON_KUDU avro/shaded/com/google/common/cache/package-info.class
NON_KUDU avro/shaded/com/google/common/base/package-info.class
NON_KUDU avro/shaded/com/google/common/math/package-info.class
NON_KUDU avro/shaded/com/google/common/primitives/package-info.class
NON_KUDU avro/shaded/com/google/common/util/concurrent/package-info.class
NON_JAVA META-INF/LICENSE.md
NON_JAVA META-INF/NOTICE.md
NON_KUDU META-INF/versions/9/javax/xml/bind/ModuleUtil.class
> ./kudu-spark/build/libs/kudu-spark3_2.12-1.18.0-SNAPSHOT.jar
> ./kudu-test-utils/build/libs/kudu-test-utils-1.18.0-SNAPSHOT.jar
> ./kudu-backup-common/build/libs/kudu-backup-common-1.18.0-SNAPSHOT.jar
http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle@26
PS17, Line 26: testImplementation
> Are you sure that's not needed in regular (i.e. not just test) runtime?
+1 on Alexey's question, the original compiles just fine.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 08:53:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 15: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/1118/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 15
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 21:38:34 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 14:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1114/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 07:11:31 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#17).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- hive - 3.1.2 -> 3.1.3
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
verify_jars.pl has been updated to include module-info.class from
micrometer library. Currently we only build on JDK 8 so this file
could be used in future when we compile with JDK 9.
mockitoCore library dependency is added to the upgraded hadoop version[1]
hadoopCommon library dependency is required for hive tests to run without
which we end up with erorr as below:
Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.fs.BatchListingOperations
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M build-support/verify_jars.pl
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
5 files changed, 29 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/17
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
> > This looks like a cleaner approach. Let me do some reading and get back t
Using platforms, the hierarchy of the project's modules would have to be reorganised. The "central" platform project would establish the dependencies and the constraints of the transitive dependencies and the dependant projects could just include the BOM provided by this platform. Maybe more than one platform could be established, e.g. spark/bdr could probably share one, and the client another. However this might be a big undertaking, so maybe consider using the transitive constraints here locally, to unblock the 1.18 release, and follow up with the restructuring in a follow-up patch.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Mar 2025 13:42:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 26: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 26
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 22:11:52 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: Upgrade Java dependencies
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 26
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 21:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37:
: shadowJar {
: dependencies {
: exclude(dependency("log4j::.*"))
: exclude(dependency("org.apache.hadoop::.*"))
: exclude(dependency("org.apache.hive::.*"))
: exclude(dependency("org.apache.hbase::.*"))
: exclude(dependency("org.apache.hbase.thirdparty::.*"))
: exclude(dependency("junit::.*"))
: exclude(dependency("javax.servlet.jsp::.*"))
:
> It's really hard to gauge how much effort this would take in my opinion. Th
So I think I figured out what was the issue here:
Q. Why is the test failing?
During the test run, hadoop-common:3.1.0 is being used the issue is encountered when loading the filesystem classes[1]. As in that version DistributedFileSystems class didn't extend BatchListingOperations class[2] unlike in 3.4.1[3] and we don't have 3.4.1 available during runtime.
Q. How did we get hadoop-common-3.1.0 in the first place?
It was a transitive dependency from hive-metastore:3.1.2
Q. Why is the test failing with hadoop-common:3.4.1 and not with hadoop-common:3.3.1?
While both the versions have DistributedFileSystems class extending BatchListingOperations, the FileSystems class from hadoop-common:3.3.1 was present from spark-core_2.12:3.2.4 -> hadoop-client-api:3.3.1 as a transitive dependency.
Q. What is the best way forward?
While I do not think we use the Filesystem class from hadoop-common in kudu-hive plugin and the chances of having the right class are pretty high in Hive-metastore server(where the plugin is used), we might be better off declaring it as implementation to be safe.
[1] https://github.com/apache/hadoop/blame/e9aa1789c2c75fd20600d2a0d11774161319af2a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L3264
[2]
https://github.com/apache/hadoop/blob/branch-3.1.0/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java#L131
[3] https://github.com/apache/hadoop/blob/626b227094027ed08883af97a0734d2db7863864/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java#L148
http://gerrit.cloudera.org:8080/#/c/22374/21/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
PS21:
> Comparing the base version and PS21, it seems there were no actual modifica
I was testing the run after clearing gradle cache in build machines. Hence this change, but I figured out the root cause of the test failure. I will be posting it under the other comment thread we have running.
http://gerrit.cloudera.org:8080/#/c/22374/21/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/21/java/kudu-test-utils/build.gradle@75
PS21, Line 75: exclude "META-INF/versions/9/module-info.class"
> Is this still necessary given there is a broader
Good spot, that is not needed aymore.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 06:06:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 22: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1232/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 22
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 06:58:54 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 8: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1062/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 02:38:16 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#9).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
2 files changed, 25 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/9
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#2).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
2 files changed, 33 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/2
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#10).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
2 files changed, 25 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/10
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#21).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
mockitoCore library dependency is added to the upgraded hadoop version[1]
Changes in shadow.gradle:
Excluding classes with Java21 as Gradle 7 doesn't recognize them.
Excluding Java9 version specific classes(module-info.class) as we compile with
Java8 and don't need them anyway.
Excluding bouncycastle due to [2]
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
[2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-client-modules/hadoop-client-runtime/pom.xml#L156-L157
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-test-utils/build.gradle
6 files changed, 31 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/21
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 13: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1110/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 13
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 23:54:15 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 15:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1118/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 15
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 20:00:34 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 21:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22374/21/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
PS21:
Comparing the base version and PS21, it seems there were no actual modifications in this file. If it's so indeed, maybe revert this file to its original form, so it's clear that this file didn't require any updates from its base version?
http://gerrit.cloudera.org:8080/#/c/22374/21/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/21/java/kudu-test-utils/build.gradle@75
PS21, Line 75: exclude "META-INF/versions/9/module-info.class"
Is this still necessary given there is a broader
'exclude' pattern in gradle/shadow.gradle ?
exclude "META-INF/versions/9/**", "META-INF/versions/21/**"
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Mar 2025 16:34:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 23:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/22/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:
PS22:
> If this file hasn't actually changed between the base and PS22, maybe rever
Done
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 23
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 17:30:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 23:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1235/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 23
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 17:30:21 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 23:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/23/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/23/java/gradle/shadow.gradle@51
PS23, Line 51: // Excluding classes with Java21 as Gradle 7 doesn't recognize them and
: // Java9 version specific classes(module-info.class) as we compile with
: // Java8 and don't need them anyway.
> I guess the current list of versions to exclude was found by trial-and-erro
As discussed offline,
1. We are excluding any unsupported Java versions by Gradle 7.6
2&3. Adding a TODO on this but going with the current approach of excluding all MR-JAR specific files.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 23
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 00:12:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20:
(1 comment)
> Patch Set 20:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
> > ... However this might be a big undertaking ...
It's really hard to gauge how much effort this would take in my opinion. This could break the packaging and shading and that would have to be reconfigured as well, which again could break something down the line. I would'n't want to hold up the 1.18.0 release with this since it's already been a relatively long release cycle.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Mar 2025 12:00:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 19: Code-Review+1
(1 comment)
one small nit, everything else looks good, thanks!
http://gerrit.cloudera.org:8080/#/c/22374/19/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/19/java/kudu-hive/build.gradle@26
PS19, Line 26: testImplementation libs.hadoopCommon
since the Hive 3.1.3 upgrade was removed in this patchset, is this still necessary?
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Mar 2025 09:30:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 26: Verified+1
unrelated test failures (TSAN):
* C++: RemoteKsckTest.TestFilterOnNoTableCluster
* Java: org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 26
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 22:11:41 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 24: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1238/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 24
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 01:30:38 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 19:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/19/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/19/java/kudu-hive/build.gradle@26
PS19, Line 26: testImplementation libs.hadoopCommon
> since the Hive 3.1.3 upgrade was removed in this patchset, is this still ne
Did some digging and found that this is not related to Hive upgrade but Hadoop upgrade. Notice the mention of hadoop-common-3.1.0.jar being referred to here. Not sure where that is coming from, but I think this is due to some internal dependency issue. We can force override to use hadoop 3.4.1 where this class is present and there shouldn't be any issue. I'll post a revised patch soon.
Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.fs.BatchListingOperations
at java.net.URLClassLoader.findClass(URLClassLoader.java:382) ~[?:1.8.0_275]
at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_275]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352) ~[?:1.8.0_275]
at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_275]
at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_275]
at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_275]
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) ~[?:1.8.0_275]
at java.net.URLClassLoader.defineClass(URLClassLoader.java:468) ~[?:1.8.0_275]
at java.net.URLClassLoader.access$100(URLClassLoader.java:74) ~[?:1.8.0_275]
at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_275]
at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_275]
at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_275]
at java.net.URLClassLoader.findClass(URLClassLoader.java:362) ~[?:1.8.0_275]
at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_275]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352) ~[?:1.8.0_275]
at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_275]
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_275]
at java.lang.Class.forName(Class.java:348) ~[?:1.8.0_275]
at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:370) ~[?:1.8.0_275]
at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404) ~[?:1.8.0_275]
at java.util.ServiceLoader$1.next(ServiceLoader.java:480) ~[?:1.8.0_275]
at org.apache.hadoop.fs.FileSystem.loadFileSystems(FileSystem.java:3268) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:3313) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:3352) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:124) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:3403) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:3371) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:477) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:226) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:461) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.fs.Path.getFileSystem(Path.java:361) ~[hadoop-common-3.1.0.jar:?]
at org.apache.hadoop.hive.metastore.Warehouse.getFs(Warehouse.java:115) ~[hive-standalone-metastore-3.1.2.jar:3.1.2]
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 02:14:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 24: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22374/24/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/24/java/gradle/shadow.gradle@55
PS24, Line 55: Current gradle version doesn't support anything above JDK19
nit: that's not exactly 'current Gradle version', but rather Gradle version used to compile Java components of the Kudu project :)
Also, do you think it makes sense to put the exact version number of Gradle here? Also, maybe it's worth it adding a reference to the Gradle's compatibility matrix for posterity -- that should help to update this later on, if needed.
https://docs.gradle.org/current/userguide/compatibility.html#java_runtime
http://gerrit.cloudera.org:8080/#/c/22374/24/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:
PS24:
nit: is it possible to revert this back to the original version since there wasn't any actual updates in this file?
It's easy to do so by reverting the patch just for this file by `patch -p1 -R < only_build_gradle.diff `
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 24
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 04:06:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 8: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1060/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 00:44:00 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 6:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1047/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Feb 2025 21:24:48 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 11: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1087/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2025 23:30:33 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 16:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1121/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 16
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 07:12:16 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 12:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1109/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 22:14:20 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 18: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1158/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Mar 2025 01:27:17 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 19: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1162/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Mar 2025 18:44:34 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
mockitoCore library dependency is added to the upgraded hadoop version[1]
Changes in shadow.gradle:
Excluding classes aove Java19 as Gradle 7.6 doesn't recognize them.
Excluding Java9 version Multi-Release JAR specific classes(module-info.class).
Excluding bouncycastle due to [2].
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
[2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-client-modules/hadoop-client-runtime/pom.xml#L156-L157
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Reviewed-on: http://gerrit.cloudera.org:8080/22374
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
5 files changed, 39 insertions(+), 27 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
Zoltan Chovan: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 27
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#26).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
mockitoCore library dependency is added to the upgraded hadoop version[1]
Changes in shadow.gradle:
Excluding classes aove Java19 as Gradle 7.6 doesn't recognize them.
Excluding Java9 version Multi-Release JAR specific classes(module-info.class).
Excluding bouncycastle due to [2].
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
[2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-client-modules/hadoop-client-runtime/pom.xml#L156-L157
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
5 files changed, 39 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/26
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 26
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 23: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1235/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 23
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 18:12:26 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#23).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
mockitoCore library dependency is added to the upgraded hadoop version[1]
Changes in shadow.gradle:
Excluding classes with Java21 as Gradle 7 doesn't recognize them.
Excluding Java9 version specific classes(module-info.class) as we compile with
Java8 and don't need them anyway.
Excluding bouncycastle due to [2]
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
[2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-client-modules/hadoop-client-runtime/pom.xml#L156-L157
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
5 files changed, 35 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/23
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 23
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 22: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: shadowJar {
: dependencies {
: exclude(dependency("log4j::.*"))
: exclude(dependency("org.apache.hadoop::.*"))
: exclude(dependency("org.apache.hive::.*"))
: exclude(dependency("org.apache.hbase::.*"))
: exclude(dependency("org.apache.hbase.thirdparty::.*"))
: exclude(dependency("junit::.*"))
: exclude(dependency("javax.servlet.jsp::.*"))
: exclude(dependency("javax.jdo::.*"))
:
> Q. Why is the test failing with hadoop-common:3.4.1 and not with hadoop-common:3.3.1?
While both the versions have DistributedFileSystems class extending BatchListingOperations, the FileSystems class from hadoop-common:3.3.1 was present from spark-core_2.12:3.2.4 -> hadoop-client-api:3.3.1 as a transitive dependency.
So, why the test was failing with 3.4.1, but not with 3.3.1 version of the hadoop-common package? The cited snippet above only explains from where a particular version came as a transitive dependency, but I could not find the explanation behind the failure of the test.
http://gerrit.cloudera.org:8080/#/c/22374/22/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:
PS22:
If this file hasn't actually changed between the base and PS22, maybe revert the formatting-only updates to keep this changelist cleaner?
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 22
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 01:16:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 18:
Thank you for revving the patch.
I haven't looked at the updates closely yet, but it seems something is off at for the org.apache.kudu.hive.metastore.TestKuduMetastorePlugin test. It's failed in all the build configurations: DEBUG, RELEASE, ASAN, TSAN. Please take a look.
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Mar 2025 02:37:02 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#19).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
mockitoCore library dependency is added to the upgraded hadoop version[1]
Changes in shadow.gradle:
Excluding classes with Java21 as Gradle 7 doesn't recognize them.
Excluding Java9 version specific classes(module-info.class) as we compile with
Java8 and don't need them anyway.
Excluding bouncycastle due to [2]
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
[2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-client-modules/hadoop-client-runtime/pom.xml#L156-L157
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-test-utils/build.gradle
6 files changed, 31 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/19
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37
PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct
: // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the
: // version which we use for hadoop-common which is said to be compatible with the current Hive
: // metastore version according to official Hive documentation:
: // https://hive.apache.org/general/downloads/
:
: configurations.all {
: resolutionStrategy {
: force libs.hadoopCommon
: }
: }
> It seems 'testImplementation libs.hadoopMRClientCommon' is needed for tests
After looking at this a bit more, I realized that migrating these transitive dependencies should have been taken care of differently than it was done in https://github.com/apache/kudu/commit/e456bc775805d4555d99ce12d04e3ca0b8950760
I guess we should take a step back and try to address the issue, namely revising the update from the 'provided' dependency type for the transitive 'optioinal' dependencies of the following:
* libs.hadoopCommon
* libs.hadoopMRClientCommon
We should take into consideration that the 'provided' is something that mirrors similar construct in Maven:
https://docs.gradle.org/current/userguide/migrating_from_maven.html#migmvn:excluding_deps
They have some comments on how to add constraints on transitive dependencies: https://docs.gradle.org/current/userguide/dependency_constraints.html#sec:adding-constraints-transitive-deps
With that, maybe we should try using so-called platforms here to avoid conflicts across different versions of components that Kudu packages have transitive dependencies of: https://docs.gradle.org/current/userguide/platforms.html#sec:using-platform-to-control-transitive-deps
What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Mar 2025 20:25:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1026/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 Feb 2025 00:07:38 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#12).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M build-support/verify_jars.pl
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
5 files changed, 29 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/12
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 14: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1115/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 17:37:12 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 11:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1071/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 22:44:22 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 11: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1071/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 13 Feb 2025 00:04:34 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 9: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1066/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 07:59:46 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 8:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1060/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 00:39:42 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#4).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
2 files changed, 31 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/4
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1030/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 Feb 2025 07:14:20 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1030/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 Feb 2025 07:37:02 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 25:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1242/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 25
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 09:03:43 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 24:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1238/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 24
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 00:18:27 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 17: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1122/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 08:05:10 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#14).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M build-support/verify_jars.pl
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
5 files changed, 29 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/14
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: [WIP] Upgrade Java dependencies
......................................................................
Patch Set 12:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1109/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 22:00:50 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.
Change subject: Upgrade Java dependencies
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [WIP] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#15).
Change subject: [WIP] Upgrade Java dependencies
......................................................................
[WIP] Upgrade Java dependencies
This patch updates several Java dependencies and Gradle versions.
I am planning to take one more pass at any potential CVEs included
and update this patch accordingly with a proper commit message.
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M build-support/verify_jars.pl
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
5 files changed, 29 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/15
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 15
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 16:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1121/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 16
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 07:13:44 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 21:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1225/
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Mar 2025 21:34:05 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#22).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
mockitoCore library dependency is added to the upgraded hadoop version[1]
Changes in shadow.gradle:
Excluding classes with Java21 as Gradle 7 doesn't recognize them.
Excluding Java9 version specific classes(module-info.class) as we compile with
Java8 and don't need them anyway.
Excluding bouncycastle due to [2]
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
[2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-client-modules/hadoop-client-runtime/pom.xml#L156-L157
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-test-utils/build.gradle
6 files changed, 35 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/22
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 22
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 22:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22374/20//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22374/20//COMMIT_MSG@44
PS20, Line 44: Changes in shadow.gradle:
: Excluding classes with Java21 as Gradle 7 doesn't recognize them.
: Excluding Java9 version specific classes(module-info.class) as we compile with
: Java8 and don't need them anyway.
: Excluding bouncycastle due to [2]
:
: [1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
: [2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a0
> Could you please in-line this information into the shadow.gradle file itsel
Done
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 22
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 06:17:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Java dependencies
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22374
to look at the new patch set (#20).
Change subject: Upgrade Java dependencies
......................................................................
Upgrade Java dependencies
Updgrades the Java dependencies and Gradle versions to mitigate
known CVE reports.
Major version upgrades:
- guava - 32.1.1-jre -> 33.3.1-jre
- hamcrest - 2.2 -> 3.0
Minor version upgrades:
- clojure - 1.10.3 -> 1.12.0
- clojuteToolsCli - 1.0.206 -> 1.1.230
- hadoop - 3.3.1 -> 3.4.1
- hdr histogram - 2.1.12 -> 2.2.2
- jmh - 1.34 -> 1.37
- log4j - 2.17.1 -> 2.24.3
- log4jCaptor - 2.9.2 -> 2.10.0
- scopt - 4.0.1 -> 4.1.0
Maintenance version upgrades:
- httpClient - 4.5.13 -> 4.5.14
- jetty - 9.4.44.v20210927 -> 9.4.57.v20241219
- scala - 2.12.15 -> 2.12.20
- scalatest - 3.2.10 -> 3.2.19
- slf4j - 1.7.33 -> 1.7.36
Gradle upgrades:
- gradle-versions-plugin - 0.41.0 -> 0.51.0
- gradle-jacoco-log - 1.2.4 -> 2.0.0
- osdetector-gradle-plugin - 1.7.0 -> 1.7.3
- nebula-clojure-plugin - 10.1.1 -> 14.2.2
- spotbugs-gradle-plugin - 4.7.0 -> 4.7.5
- gradle-animalsniffer-plugin - 1.5.4 -> 1.7.2
- guava - 31.0.1-jre -> 33.4.0-jre
mockitoCore library dependency is added to the upgraded hadoop version[1]
Changes in shadow.gradle:
Excluding classes with Java21 as Gradle 7 doesn't recognize them.
Excluding Java9 version specific classes(module-info.class) as we compile with
Java8 and don't need them anyway.
Excluding bouncycastle due to [2]
[1] https://issues.apache.org/jira/browse/MAPREDUCE-7471
[2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-client-modules/hadoop-client-runtime/pom.xml#L156-L157
Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-test-utils/build.gradle
6 files changed, 42 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22374/20
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Upgrade Java dependencies
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies
......................................................................
Patch Set 20: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1174/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 02:59:17 +0000
Gerrit-HasComments: No