You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Elliotte Rusty Harold (Jira)" <ji...@apache.org> on 2023/06/03 11:26:00 UTC

[jira] [Commented] (MINVOKER-339) Don't print the plugin's stack trace on verification fail

    [ https://issues.apache.org/jira/browse/MINVOKER-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728957#comment-17728957 ] 

Elliotte Rusty Harold commented on MINVOKER-339:
------------------------------------------------

Worth noting: the actual information needed to understand and diagnose the failure is not included in the copious console output. It's hiding in "/home/jenkins/jenkins-home/workspace/_box_maven-jarsigner-plugin_PR-8@2@2/linux-jdk8-m3.8.x_build/target/it/verify-fail/build.log" or similar location, which is a PITA to get from a CI system.

Very typically, maven-invoker emits page after page of information that isn't needed and in no way helps the developer while leaving out the information that developer does need. 



> Don't print the plugin's stack trace on verification fail
> ---------------------------------------------------------
>
>                 Key: MINVOKER-339
>                 URL: https://issues.apache.org/jira/browse/MINVOKER-339
>             Project: Maven Invoker Plugin
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Priority: Major
>
> Typical output on a failing IT. The stack trace is unhelpful and pointless log junk. It does not point to the actual failing test, why and how it failed, or its output  (which is in fact not included and should be, but that's a separate issue.) Instead all it shows is a stack trace of the code from Maven and the maven-invoker-plugin that ran the code. This is *not* the failing code. This is only the code that invoked the failing code, and this code executed successfully.
> This code did not fail and is not the cause of the bug, nor is it helpful in diagnosing the bug. The maven-invoker plugin executed successfully and correctly detected a failing integration test. Its stack trace simply obscures the real problem and gets in the way of the developer. Don't print it. 
> {{*** end build.log for: verify-fail/pom.xml ***
> Error:  -------------------------------------------------
> Error:  
> [INFO] -------------------------------------------------
> [INFO] Build Summary:
> [INFO]   Passed: 8, Failed: 1, Errors: 0, Skipped: 0
> [INFO] -------------------------------------------------
> Error:  The following builds failed:
> Error:  *  verify-fail/pom.xml
> [INFO] -------------------------------------------------
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  53.844 s
> [INFO] Finished at: 2023-06-03T10:58:12Z
> [INFO] ------------------------------------------------------------------------
> Error:  Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.3.0:verify (integration-test) on project maven-jarsigner-plugin: 1 build failed. See console output above for details. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.3.0:verify (integration-test) on project maven-jarsigner-plugin: 1 build failed. See console output above for details.
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:375)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
>     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
>     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
>     at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
>     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:566)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
>     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:566)
>     at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:47)
>     at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:156)
>     at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:72)
> Caused by: org.apache.maven.plugin.MojoFailureException: 1 build failed. See console output above for details.
>     at org.apache.maven.plugins.invoker.InvokerSession.handleFailures (InvokerSession.java:285)
>     at org.apache.maven.plugins.invoker.VerifyMojo.execute (VerifyMojo.java:153)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
>     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
>     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
>     at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
>     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:566)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
>     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:566)
>     at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:47)
>     at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:156)
>     at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:72)}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)