You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/06 17:29:48 UTC

[GitHub] [incubator-druid] leventov commented on a change in pull request #8060: 6855 add Checkstyle for constant name static final

leventov commented on a change in pull request #8060: 6855 add Checkstyle for constant name static final 
URL: https://github.com/apache/incubator-druid/pull/8060#discussion_r311178659
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/data/CompressionStrategy.java
 ##########
 @@ -306,8 +306,8 @@ public void decompress(ByteBuffer in, int numBytes, ByteBuffer out)
 
   public static class LZ4Compressor extends Compressor
   {
-    private static final LZ4Compressor defaultCompressor = new LZ4Compressor();
-    private static final net.jpountz.lz4.LZ4Compressor lz4High = LZ4Factory.fastestInstance().highCompressor();
+    private static final LZ4Compressor DEFAULT_COMPRESSOR = new LZ4Compressor();
+    private static final net.jpountz.lz4.LZ4Compressor LZ_4_HIGH = LZ4Factory.fastestInstance().highCompressor();
 
 Review comment:
   Please call `LZ4_HIGH`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org