You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/10/09 03:23:32 UTC
[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth
emkornfield commented on code in PR #995:
URL: https://github.com/apache/parquet-mr/pull/995#discussion_r990725805
##########
parquet-protobuf/src/test/java/org/apache/parquet/proto/ProtoSchemaConverterTest.java:
##########
@@ -82,264 +93,447 @@ public void testConvertAllDatatypes() throws Exception {
* Tests that all protocol buffer datatypes are converted to correct parquet datatypes.
*/
@Test
- public void testProto3ConvertAllDatatypes() throws Exception {
- String expectedSchema =
- "message TestProto3.SchemaConverterAllDatatypes {\n" +
- " optional double optionalDouble = 1;\n" +
- " optional float optionalFloat = 2;\n" +
- " optional int32 optionalInt32 = 3;\n" +
- " optional int64 optionalInt64 = 4;\n" +
- " optional int32 optionalUInt32 = 5;\n" +
- " optional int64 optionalUInt64 = 6;\n" +
- " optional int32 optionalSInt32 = 7;\n" +
- " optional int64 optionalSInt64 = 8;\n" +
- " optional int32 optionalFixed32 = 9;\n" +
- " optional int64 optionalFixed64 = 10;\n" +
- " optional int32 optionalSFixed32 = 11;\n" +
- " optional int64 optionalSFixed64 = 12;\n" +
- " optional boolean optionalBool = 13;\n" +
- " optional binary optionalString (UTF8) = 14;\n" +
- " optional binary optionalBytes = 15;\n" +
- " optional group optionalMessage = 16 {\n" +
- " optional int32 someId = 3;\n" +
- " }\n" +
- " optional binary optionalEnum (ENUM) = 18;" +
- " optional int32 someInt32 = 19;" +
- " optional binary someString (UTF8) = 20;" +
- " optional group optionalMap (MAP) = 21 {\n" +
- " repeated group key_value {\n" +
- " required int64 key;\n" +
- " optional group value {\n" +
- " optional int32 someId = 3;\n" +
- " }\n" +
- " }\n" +
- " }\n" +
- "}";
+ public void testProto3ConvertAllDatatypes() {
+ String expectedSchema = JOINER.join(
Review Comment:
is it possible to separate this tpe of code style cleanup from functional changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org