You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/05 21:39:33 UTC
[GitHub] [superset] justinpark opened a new pull request, #22609: fix(sqllab): Overflow bigint in json-tree view
justinpark opened a new pull request, #22609:
URL: https://github.com/apache/superset/pull/22609
### SUMMARY
The json explore view in sqllab is displaying incorrect values which seemed to be due to Javascript's max integer on 64 bit IDs.
This commit updates the JSON.parser by JSONBig parser as well as custom rendering logic to trim the unnecessary quote format in a bigint string format.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
- Before
https://user-images.githubusercontent.com/1392866/210884982-67147df3-1575-40a8-8b1a-658a4b4bac8a.mov
- After
https://user-images.githubusercontent.com/1392866/210884977-232a1e40-a9ae-4b24-98c6-7a8a1ceb6149.mov
### TESTING INSTRUCTIONS
specs are added
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
@ktmud cc: @john-bodley
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22609: fix(sqllab): Overflow bigint in json-tree view
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22609:
URL: https://github.com/apache/superset/pull/22609#issuecomment-1372874072
# [Codecov](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22609](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (157ac14) into [master](https://codecov.io/gh/apache/superset/commit/82b0c23fb294808bba931fc052ce438d0f2f5c45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82b0c23) will **increase** coverage by `0.00%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #22609 +/- ##
=======================================
Coverage 55.91% 55.91%
=======================================
Files 1859 1859
Lines 71019 71022 +3
Branches 7766 7767 +1
=======================================
+ Hits 39710 39713 +3
Misses 29287 29287
Partials 2022 2022
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.86% <75.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/FilterableTable/index.tsx](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL2luZGV4LnRzeA==) | `73.11% <75.00%> (+0.44%)` | :arrow_up: |
| [...tend/plugins/legacy-plugin-chart-rose/src/index.js](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL2luZGV4Lmpz) | `66.66% <0.00%> (ø)` | |
| [...nd/plugins/plugin-chart-echarts/src/Gauge/index.ts](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR2F1Z2UvaW5kZXgudHM=) | `50.00% <0.00%> (ø)` | |
| [...nd/plugins/plugin-chart-echarts/src/Graph/index.ts](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR3JhcGgvaW5kZXgudHM=) | `50.00% <0.00%> (ø)` | |
| [...nd/plugins/plugin-chart-echarts/src/Radar/index.ts](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvUmFkYXIvaW5kZXgudHM=) | `50.00% <0.00%> (ø)` | |
| [...d/plugins/plugin-chart-echarts/src/Funnel/index.ts](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvRnVubmVsL2luZGV4LnRz) | `50.00% <0.00%> (ø)` | |
| [...lugins/legacy-plugin-chart-event-flow/src/index.ts](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWV2ZW50LWZsb3cvc3JjL2luZGV4LnRz) | `50.00% <0.00%> (ø)` | |
| [...lugins/plugin-chart-handlebars/src/plugin/index.ts](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvcGx1Z2luL2luZGV4LnRz) | `66.66% <0.00%> (ø)` | |
| [...c/visualizations/FilterBox/FilterBoxChartPlugin.js](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3hDaGFydFBsdWdpbi5qcw==) | `66.66% <0.00%> (ø)` | |
| [...ins/legacy-preset-chart-nvd3/src/DualLine/index.js](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0R1YWxMaW5lL2luZGV4Lmpz) | `66.66% <0.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/22609?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #22609: fix(sqllab): Overflow bigint in json-tree view
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #22609:
URL: https://github.com/apache/superset/pull/22609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org