[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6021: minor: Remove compact row since it's no longer used

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #6021:
URL: https://github.com/apache/arrow-datafusion/pull/6021#discussion_r1167589937


##########
datafusion/row/src/accessor.rs:
##########
@@ -116,9 +116,9 @@ macro_rules! fn_get_idx_scalar {
 
 impl<'a> RowAccessor<'a> {
     /// new
-    pub fn new(schema: &Schema, row_type: RowType) -> Self {

Review Comment:
   Thanks for the PR. This is always great to cut out the unused code. For public functions though it can be a user interface change for downstream projects btw? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org