You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "hemantk-12 (via GitHub)" <gi...@apache.org> on 2023/11/29 00:29:13 UTC
[PR] HDDS-9779. Migrated TestOmSnapshot to Junit5 [ozone]
hemantk-12 opened a new pull request, #5696:
URL: https://github.com/apache/ozone/pull/5696
## What changes were proposed in this pull request?
This change is to migrate TestOmSnapshot to Junit5. Currently we use Junit4 parameterize test and initialized cluster based on the bucket layout and some other parameter.
To migrate TestOmSnapshot to Junit5, we are using inheritance. Cluster setup and tests are defined in abstract class `TestOmSnapshot` and sub-classes initialize the super class with necessary parameters.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9779
## How was this patch tested?
Verified that all the sub-classes ([TestOmSnapshotFsoWithoutNativeLib](https://github.com/hemantk-12/ozone/actions/runs/7023339913/job/19110596541#step:6:161), [TestOmSnapshotFsoWithoutNativeLib](https://github.com/hemantk-12/ozone/actions/runs/7023339913/job/19110596541#step:6:163), [TestOmSnapshotObjectStore](https://github.com/hemantk-12/ozone/actions/runs/7023339913/job/19110596541#step:6:169) and [TestOmSnapshotFsoWithNativeLib](https://github.com/hemantk-12/ozone/actions/runs/7023339913/job/19110596541#step:6:171)) ran on fork branch.
```
[INFO] Running org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFsoWithoutNativeLib
[INFO] Tests run: 42, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 186.878 s - in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFsoWithoutNativeLib
[INFO] Running org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotLegacy
Warning: Tests run: 42, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 166.778 s - in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotLegacy
...
[INFO] Running org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotObjectStore
Warning: Tests run: 42, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 166.55 s - in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotObjectStore
[INFO] Running org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFsoWithNativeLib
[INFO] Tests run: 42, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 190.542 s - in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFsoWithNativeLib
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9779. Migrated TestOmSnapshot to Junit5 [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on PR #5696:
URL: https://github.com/apache/ozone/pull/5696#issuecomment-1832776790
Thanks for the review @adoroszlai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9779. Migrated TestOmSnapshot to Junit5 [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 merged PR #5696:
URL: https://github.com/apache/ozone/pull/5696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org