You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by te...@apache.org on 2022/10/20 02:27:43 UTC
[pulsar] branch branch-2.11 updated: [improve][ml] Reduce unnecessary calling `span()` when filtering read entries. (#18106)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.11 by this push:
new ae4b8e2a8fc [improve][ml] Reduce unnecessary calling `span()` when filtering read entries. (#18106)
ae4b8e2a8fc is described below
commit ae4b8e2a8fc8d67d5ede1553eedad3457e87c7b9
Author: Cong Zhao <zh...@apache.org>
AuthorDate: Thu Oct 20 10:26:40 2022 +0800
[improve][ml] Reduce unnecessary calling `span()` when filtering read entries. (#18106)
---
.../java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
index e610a0a35c9..6de68580826 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
@@ -2285,8 +2285,8 @@ public class ManagedCursorImpl implements ManagedCursor {
log.debug("[{}] [{}] Filtering entries {} - alreadyDeleted: {}", ledger.getName(), name, entriesRange,
individualDeletedMessages);
}
- if (individualDeletedMessages.isEmpty() || individualDeletedMessages.span() == null
- || !entriesRange.isConnected(individualDeletedMessages.span())) {
+ Range<PositionImpl> span = individualDeletedMessages.isEmpty() ? null : individualDeletedMessages.span();
+ if (span == null || !entriesRange.isConnected(span)) {
// There are no individually deleted messages in this entry list, no need to perform filtering
if (log.isDebugEnabled()) {
log.debug("[{}] [{}] No filtering needed for entries {}", ledger.getName(), name, entriesRange);