[jira] [Commented] (MINIFI-156) Implement NiFi Windows Script fixes in MiNiFi Java

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFI-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725941#comment-15725941 ] 

ASF GitHub Bot commented on MINIFI-156:
---------------------------------------

GitHub user brosander opened a pull request:

    https://github.com/apache/nifi-minifi/pull/62

    MINIFI-156 - Windows script fixes from NiFi

    Thank you for submitting a contribution to Apache NiFi - MiNiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
    - [x] - N/A - Have you written or updated unit tests to verify your changes?
    - [x] - N/A - If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] - N/A - If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
    - [x] - N/A - If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
    
    ### For documentation related changes:
    - [x] - N/A - Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi-minifi MINIFI-156

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #62
    
----
commit c3f8e11b11d56d01960bcb753aa389b0496d5a1b
Author: Bryan Rosander <br...@apache.org>
Date:   2016-12-06T15:58:41Z

    MINIFI-156 - Windows script fixes from NiFi

----


> Implement NiFi Windows Script fixes in MiNiFi Java
> --------------------------------------------------
>
>                 Key: MINIFI-156
>                 URL: https://issues.apache.org/jira/browse/MINIFI-156
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>            Reporter: Bryan Rosander
>            Assignee: Bryan Rosander
>            Priority: Minor
>
> NIFI-3131 and NIFI-3132 contain fixes to the sh files to allow them to work from cygwin and fixes to the bat files to allow them to work from working directories other than bin.
> NIFI-3131 also keeps the toolkit bat from popping a directory without pushing one, resulting in a working directory change.
> We need to make these same changes to MiNiFi to keep parity and make the Windows experience better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)