You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/13 05:57:00 UTC
[GitHub] [flink-table-store] LadyForest opened a new pull request, #153: [hotfix] Let ALTER TABLE COMPACT throw exception for APPEND ONLY table
LadyForest opened a new pull request, #153:
URL: https://github.com/apache/flink-table-store/pull/153
Before supporting append-only table compaction, we should check and throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #153: [hotfix] Let ALTER TABLE COMPACT throw exception for APPEND ONLY table
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #153:
URL: https://github.com/apache/flink-table-store/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #153: [hotfix] Let ALTER TABLE COMPACT throw exception for APPEND ONLY table
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #153:
URL: https://github.com/apache/flink-table-store/pull/153#discussion_r895362426
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/StoreSink.java:
##########
@@ -119,6 +119,10 @@ public StatefulPrecommittingSinkWriter<WriterStateT> createWriter(InitContext in
public StatefulPrecommittingSinkWriter<WriterStateT> restoreWriter(
InitContext initContext, Collection<WriterStateT> states) throws IOException {
if (compactionTask) {
+ if (writeMode == WriteMode.APPEND_ONLY) {
Review Comment:
We should avoid this in compile phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org