You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2018/10/12 18:37:00 UTC
[jira] [Commented] (SAMZA-1888) minor improvements for the after
commit for KafkaSystemAdmin and KafkaSystemConsumer.
[ https://issues.apache.org/jira/browse/SAMZA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648283#comment-16648283 ]
Boris Shkolnik commented on SAMZA-1888:
---------------------------------------
also fix the following warnings:
:samza-kafka_2.11:javadoc
/Users/pmaheshw/code/work/prateekm-samza/samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java:113: warning: no @param for <K>
public static <K,V> KafkaConsumer<K, V> createKafkaConsumerImpl(String systemName,
^
/Users/pmaheshw/code/work/prateekm-samza/samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java:113: warning: no @param for <V>
public static <K,V> KafkaConsumer<K, V> createKafkaConsumerImpl(String systemName,
^
/Users/pmaheshw/code/work/prateekm-samza/samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java:316: warning: no @param for tp
public static TopicAndPartition toTopicAndPartition(TopicPartition tp) {
^
/Users/pmaheshw/code/work/prateekm-samza/samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java:316: warning: no @return
public static TopicAndPartition toTopicAndPartition(TopicPartition tp) {
^
/Users/pmaheshw/code/work/prateekm-samza/samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java:323: warning: no @param for ssp
public static TopicPartition toTopicPartition(SystemStreamPartition ssp) {
^
/Users/pmaheshw/code/work/prateekm-samza/samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java:323: warning: no @return
public static TopicPartition toTopicPartition(SystemStreamPartition ssp) {
^
/Users/pmaheshw/code/work/prateekm-samza/samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java:85: warning: no @param for kafkaConsumer
public KafkaSystemConsumer(Consumer<K, V> kafkaConsumer, String systemName, Config config, String clientId,
^
/Users/pmaheshw/code/work/prateekm-samza/samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java:85: warning: no @param for clientId
public KafkaSystemConsumer(Consumer<K, V> kafkaConsumer, String systemName, Config config, String clientId,
> minor improvements for the after commit for KafkaSystemAdmin and KafkaSystemConsumer.
> -------------------------------------------------------------------------------------
>
> Key: SAMZA-1888
> URL: https://issues.apache.org/jira/browse/SAMZA-1888
> Project: Samza
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Major
>
> consider documents on the following:
> # usage of zookeeper connect, still needed for AdminClient (not for KafkaConsumer)
> # timeout for the Kafka client
> # buffer size for Kafka Client
> # Create a separate class to handle JobName and JobId together (extend Pair<String, String> ?)
> # update documentation for new KafkaSystemConsumer (change in configs)
> # review KafkaSystemAdmin.start() usage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)