You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/21 08:18:14 UTC
[GitHub] [incubator-inlong] healchow opened a new pull request #2629: [INLONG-2624][Dashboard] Modify the interface and parameters to adapt to changes in the Manager
healchow opened a new pull request #2629:
URL: https://github.com/apache/incubator-inlong/pull/2629
### Title Name: [INLONG-2624][Dashboard] Modify the interface and parameters to adapt to changes in the Manager
Fixes #2624
### Motivation
Modify the interface and parameters to adapt to changes in the Manager.
### Verifying this change
- [X] Make sure that the change passes the CI checks.
This change is a trivial rework/code cleanup without any test coverage.
### Documentation
- Does this pull request introduces a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2629: [INLONG-2624][Dashboard] Modify the interface and parameters to adapt to changes in the Manager
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2629:
URL: https://github.com/apache/incubator-inlong/pull/2629#discussion_r811136552
##########
File path: inlong-dashboard/src/pages/AccessCreate/DataStream/helper.ts
##########
@@ -27,7 +27,7 @@ export const valuesToData = (values, inlongGroupId) => {
dataSourceType,
dataSourceBasicId,
dataSourcesConfig = [],
- dataStorage = [],
+ sinkInfo = [],
Review comment:
OK, I rename this field to `streamSink`, as the `dataStorage` was changed to `streamSink` in the Manager module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] leezng commented on a change in pull request #2629: [INLONG-2624][Dashboard] Modify the interface and parameters to adapt to changes in the Manager
Posted by GitBox <gi...@apache.org>.
leezng commented on a change in pull request #2629:
URL: https://github.com/apache/incubator-inlong/pull/2629#discussion_r810996014
##########
File path: inlong-dashboard/src/pages/AccessCreate/DataStream/helper.ts
##########
@@ -27,7 +27,7 @@ export const valuesToData = (values, inlongGroupId) => {
dataSourceType,
dataSourceBasicId,
dataSourcesConfig = [],
- dataStorage = [],
+ sinkInfo = [],
Review comment:
This may affect https://github.com/healchow/incubator-inlong/blob/master/inlong-dashboard/src/components/AccessHelper/FieldsConfig/dataFields.tsx#L300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #2629: [INLONG-2624][Dashboard] Modify the interface and parameters to adapt to changes in the Manager
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #2629:
URL: https://github.com/apache/incubator-inlong/pull/2629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org