You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Eason09053360 (via GitHub)" <gi...@apache.org> on 2026/09/14 12:15:13 UTC
[PR] Fix bare traceback from kubernetes cleanup-pods without kube config [airflow]
Eason09053360 opened a new pull request, #73121:
URL: https://github.com/apache/airflow/pull/73121
## Why
`airflow kubernetes cleanup-pods` is normally run unattended from a CronJob. When it cannot reach a kube config — no `~/.kube/config`, `in_cluster` set but not actually running in a pod, an expired `exec` credential plugin — `get_kube_client()` raises `kubernetes.config.ConfigException` and nothing catches it, so the job log gets a ten-frame traceback that reads like an Airflow crash instead of the environment problem it is:
```
$ airflow kubernetes cleanup-pods --namespace default
Traceback (most recent call last):
... 9 frames ...
kubernetes.config.config_exception.ConfigException: Invalid kube-config file. No configuration found.
```
The rest of the CLI already answers this class of user error with a single line (e.g. `dags test --conf` on invalid JSON), so this is just a gap.
There is a second way the same exception escapes: `_delete_pod` called `get_kube_client()` itself, once per deleted pod, and the surrounding `except ApiException` does not cover `ConfigException`. A cleanup run can therefore die with the same raw traceback halfway through, after deleting some pods, if the kube config becomes unloadable mid-run (exec-credential plugin failure, token rotation).
## What
`providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/cli/kubernetes_command.py`:
- `cleanup_pods` catches `ConfigException` from `get_kube_client()` and exits with `SystemExit(f"Could not load Kubernetes configuration: {e}")` — one line on stderr, exit code still 1, stdout untouched. Only config-loading failures are caught; API and network errors still surface as before.
- `_delete_pod` takes the already-built client instead of calling `get_kube_client()` again. This leaves a single config-loading site in the command (the guarded one) and drops the kube config from being re-read once per deleted pod.
Tests cover both: `test_unloadable_kube_config_exits_with_message` asserts the exact message, and `test_kube_config_is_loaded_once_and_reused_for_deletions` uses two pods so it fails (3 calls) without the `_delete_pod` change. Existing `_delete_pod` assertions were updated for the new argument.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5)
Generated-by: Claude Code (Opus 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bare traceback from kubernetes cleanup-pods without kube config [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #73121:
URL: https://github.com/apache/airflow/pull/73121#issuecomment-5839080225
Hello @Eason09053360 - thank you for your contributions to Apache Airflow!
The Airflow community has introduced a limit of **5 open pull requests at a time** for contributors without write access to the repository. You currently have 33 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
* #70935 - Return only the latest Dag version from iter_all_latest_version_dags
* #72145 - Fix airflow config get-value silently succeeding on a missing option
* #72468 - Fix airflowctl tracebacks on an unusable credentials file
* #72600 - Make suppress_logs_and_warning CLI decorator return the wrapped result
* #72656 - Fix dateless dag.test and tasks test destroying unrelated Dag runs
* #72675 - Fix airflowctl commands crashing instead of printing their result
* #72893 - Show a clean error when airflow backfill create targets an unknown Dag
* #72941 - Fix tasks clear --task-regex matching as a plain substring
* #73033 - Speed up airflow dags list on deployments with many Dags
* #73070 - Fix airflow dags next-execution crashing on --field data_interval.start
* #73083 - Fix airflow connections import corrupting JSON values in .env files
* #73112 - Fix structlog log assertions never matching a single-field dict
* #73120 - Fix misleading type errors from expand_kwargs and default_args
* #73121 - Fix bare traceback from kubernetes cleanup-pods without kube config
* #73132 - Fix airflowctl pools export/import dropping pool team ownership
* #73157 - Mask extra and credentials in connections list --hide-sensitive
* #73228 - Fix missing task alert emails on Dags using native template rendering
* #73348 - Stop providers lazy-loaded from writing the default config
* #73371 - Fix api-server --apps silently dropping apps and accepting typos
* #73373 - Fix Task SDK dry-run mode crashing on task instance start
* #73377 - Fix CLI --bundle-name finding no Dags in Git bundles
* #73379 - Fix empty audit log dag_id for DAG.cli() subcommands
* #73387 - Drop ignored --bundle-name and --dagfile-path from DAG.cli()
* #73400 - Fix indexing mapped task results with a NumPy integer
* #73409 - Respect maximum_page_limit in batch list endpoints
* #73422 - Stop the JWT revocation check stalling the API server event loop
* #73424 - Fix task instance 404 detail being a JSON array instead of a string
* #73463 - API: Remove unreachable Accept branch and last deprecated 422 alias
* #73465 - API: Cap run_ids on the grid TI summaries stream endpoint
* #73472 - Rate-limit JWKS fetch attempts while the endpoint is down
* #73514 - UI: Fix grid columns vanishing when a Dag version has been cleaned
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
* #73141 - Fix scheduler refusing to start when [scheduler] only_idle is enabled
* #73154 - Batch Team lookups when syncing Dag bundles to the database
This is **not** a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.
What we ask you to do is to make your **first prioritization decision**: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or `gh pr reopen <PR_NUMBER> --repo apache/airflow`. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.
While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.
Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bare traceback from kubernetes cleanup-pods without kube config [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #73121: Fix bare traceback from kubernetes cleanup-pods without kube config
URL: https://github.com/apache/airflow/pull/73121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org