[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

[GitBox <gi...@apache.org>]

acassis commented on a change in pull request #1958:
URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r511637105



##########
File path: arch/xtensa/src/esp32/esp32_allocateheap.c
##########
@@ -77,8 +77,13 @@
 void up_allocate_heap(FAR void **heap_start, size_t *heap_size)
 {
   board_autoled_on(LED_HEAPALLOCATE);
+#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM

Review comment:
       A small typo: SEPERATE -> SEPARATE

##########
File path: arch/xtensa/Kconfig
##########
@@ -81,6 +81,16 @@ config XTENSA_CP_INITSET
 		is provided by CONFIG_XTENSA_CP_INITSET.  Each bit corresponds to one
 		coprocessor with the same bit layout as for the CPENABLE register.
 
+config XTENSA_USE_SEPERATE_IMEM

Review comment:
       A small typo: SEPERATE -> SEPARATE

##########
File path: arch/xtensa/src/common/xtensa_createstack.c
##########
@@ -73,6 +73,18 @@
 #define STACK_ALIGN_DOWN(a) ((a) & ~STACK_ALIGN_MASK)
 #define STACK_ALIGN_UP(a)   (((a) + STACK_ALIGN_MASK) & ~STACK_ALIGN_MASK)
 
+#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM

Review comment:
       SEPERATE -> SEPARATE

##########
File path: arch/xtensa/Kconfig
##########
@@ -91,6 +91,11 @@ config XTENSA_IMEM_REGION_SIZE
 	range 0x2000 0x28000
   default 0x28000
 
+config XTENSA_IMEM_PROCFS
+  bool "Internal memory PROCFS support"
+  default n
+	depends on XTENSA_USE_SEPERATE_IMEM && !DISABLE_MOUNTPOINT && FS_PROCFS && FS_PROCFS_REGISTER

Review comment:
       please align "depends on" below "default n"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org