You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/30 05:12:48 UTC

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6002: [IOTDB-3258] implement count nodes

xingtanzjr commented on code in PR #6002:
URL: https://github.com/apache/iotdb/pull/6002#discussion_r881287491


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/Analyzer.java:
##########
@@ -1282,6 +1283,31 @@ public Analysis visitCountLevelTimeSeries(
       return analysis;
     }
 
+    @Override
+    public Analysis visitCountNodes(CountNodesStatement countStatement, MPPQueryContext context) {

Review Comment:
   Most part of codes in this method is duplicated with `visitShowChildPaths()`. Suggest to merge them with a private method



##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/executor/ConfigRequestExecutor.java:
##########
@@ -252,35 +253,53 @@ public void loadSnapshot(File latestSnapshotRootDir) {
             });
   }
 
-  private DataSet getSchemaNodeManagementPartiton(ConfigRequest req)
+  private DataSet getSchemaNodeManagementPartition(ConfigRequest req)
       throws UnknownPhysicalPlanTypeException {
-    Pair<Set<String>, Set<PartialPath>> matchedChildInNextLevel;
+    int level = -1;

Review Comment:
   Unnecessary initialization here for `level`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org