You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/06 17:23:55 UTC
[GitHub] [flink] zhuzhurk opened a new pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
zhuzhurk opened a new pull request #12011:
URL: https://github.com/apache/flink/pull/12011
## What is the purpose of the change
This PR is to unify slot request timeout handling for streaming and batch tasks regarding whether the slot will be occupied indefinitely.
It is a pre-requisite of bulk slot allocation so that we do not need to maintain 2 different slot timeout handling.
## Brief change log
See commits.
## Verifying this change
- *Added unit tests for slot occupation*
- *Existing SlotPoolBatchSlotRequestTest and SlotPoolPendingRequestFailureTest help to verify the change on batch and streaming jobs*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-625343503
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624791772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"triggerType" : "PUSH"
}, {
"hash" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703",
"triggerID" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97efd201ad9b8f206e53c4e12998f68c9cc0159a UNKNOWN
* 12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624791772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"triggerType" : "PUSH"
}, {
"hash" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703",
"triggerID" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97efd201ad9b8f206e53c4e12998f68c9cc0159a UNKNOWN
* 12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624791772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"triggerType" : "PUSH"
}, {
"hash" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97efd201ad9b8f206e53c4e12998f68c9cc0159a UNKNOWN
* 12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624783473
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 97efd201ad9b8f206e53c4e12998f68c9cc0159a (Wed May 06 17:27:20 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624791772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"triggerType" : "PUSH"
}, {
"hash" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703",
"triggerID" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"triggerType" : "PUSH"
}, {
"hash" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=729",
"triggerID" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97efd201ad9b8f206e53c4e12998f68c9cc0159a UNKNOWN
* f635edd1d9f634fd51a7ef6530a1812c62adf3ca Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=729)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624791772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97efd201ad9b8f206e53c4e12998f68c9cc0159a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624791772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"triggerType" : "PUSH"
}, {
"hash" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703",
"triggerID" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"triggerType" : "PUSH"
}, {
"hash" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97efd201ad9b8f206e53c4e12998f68c9cc0159a UNKNOWN
* 12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703)
* f635edd1d9f634fd51a7ef6530a1812c62adf3ca UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624791772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"triggerType" : "PUSH"
}, {
"hash" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703",
"triggerID" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"triggerType" : "PUSH"
}, {
"hash" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=729",
"triggerID" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"triggerType" : "PUSH"
}, {
"hash" : "1addb70f0f971db762eba06c3ac4319c069a7dec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1addb70f0f971db762eba06c3ac4319c069a7dec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97efd201ad9b8f206e53c4e12998f68c9cc0159a UNKNOWN
* f635edd1d9f634fd51a7ef6530a1812c62adf3ca Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=729)
* 1addb70f0f971db762eba06c3ac4319c069a7dec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624791772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"triggerType" : "PUSH"
}, {
"hash" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703",
"triggerID" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"triggerType" : "PUSH"
}, {
"hash" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=729",
"triggerID" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"triggerType" : "PUSH"
}, {
"hash" : "1addb70f0f971db762eba06c3ac4319c069a7dec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=805",
"triggerID" : "1addb70f0f971db762eba06c3ac4319c069a7dec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97efd201ad9b8f206e53c4e12998f68c9cc0159a UNKNOWN
* 1addb70f0f971db762eba06c3ac4319c069a7dec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=805)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12011: [FLINK-17542] Unify slot request timeout handling for streaming and batch tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12011:
URL: https://github.com/apache/flink/pull/12011#issuecomment-624791772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97efd201ad9b8f206e53c4e12998f68c9cc0159a",
"triggerType" : "PUSH"
}, {
"hash" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=703",
"triggerID" : "12a03aeea4dc42a2d2bb1a4f9d885ddb2ecd0b22",
"triggerType" : "PUSH"
}, {
"hash" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=729",
"triggerID" : "f635edd1d9f634fd51a7ef6530a1812c62adf3ca",
"triggerType" : "PUSH"
}, {
"hash" : "1addb70f0f971db762eba06c3ac4319c069a7dec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=805",
"triggerID" : "1addb70f0f971db762eba06c3ac4319c069a7dec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97efd201ad9b8f206e53c4e12998f68c9cc0159a UNKNOWN
* f635edd1d9f634fd51a7ef6530a1812c62adf3ca Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=729)
* 1addb70f0f971db762eba06c3ac4319c069a7dec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=805)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org