[GitHub] [pulsar] sijie commented on pull request #6814: Expose managed ledger bookie client metric to prometheus

[GitBox <gi...@apache.org>]

sijie commented on pull request #6814:
URL: https://github.com/apache/pulsar/pull/6814#issuecomment-625060007


   @hangc0276 sorry for late response. I generally don't think copying the files and maintain another implementation in Pulsar is a good idea. 
   
   > bookkeeper's prometheus statsProvider will open an individual ip:port
   
   the prometheus stats provider also work well with bookie HTTP server as well. There is a flag to disable the prometheus HTTP server in the stats provider by setting `prometheusStatsHttpEnable` to `false`.
   
   https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java#L63
   
   > some components of bookkeeper's prometheus statsProvider dependent
   
   Why do you need to access those components? Can't you use the bookkeeper stats library? You can always use `Stats.loadProvider` to load the stats provider, no?
   
   https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/Stats.java#L43
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org