You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Frun1na (via GitHub)" <gi...@apache.org> on 2026/09/22 05:46:35 UTC
[I] [Bug] rmqctl skips MCP session re-initialization when a 404 races a concurrent send [rocketmq-dashboard]
Frun1na opened a new issue, #4880:
URL: https://github.com/apache/rocketmq-dashboard/issues/4880
### Is your feature request related to a problem? Please describe.
`rmqctl`'s MCP client decides whether a terminated session can be re-initialized from `transport.GetSessionId() != ""`. The mcp-go Streamable HTTP transport clears its stored session id as soon as any request fails with a 404 (`sessionID.CompareAndSwap(sessionID, "")`). When two concurrent sends both hit a terminated session, the second sender's snapshot is taken after that clearing, so it sees an empty id, skips the reinitialize, and surfaces `session terminated (404)` to the caller even though reconnecting was possible.
### Describe the solution you'd like
Base the reconnect decision on the recorded initialize request (`state.initialize != nil`) instead of the transport's session id. The generation check inside `reinitialize` already keeps concurrent senders serialized.
### Additional context
Fix in https://github.com/apache/rocketmq-dashboard/pull/4876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] rmqctl skips MCP session re-initialization when a 404 races a concurrent send [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #4880: [Bug] rmqctl skips MCP session re-initialization when a 404 races a concurrent send
URL: https://github.com/apache/rocketmq-dashboard/issues/4880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] rmqctl skips MCP session re-initialization when a 404 races a concurrent send [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #4880:
URL: https://github.com/apache/rocketmq-dashboard/issues/4880#issuecomment-5771974810
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
The reported race condition is valid. When two concurrent sends hit a terminated session, the second sender sees an empty session ID (cleared by the 404 response) and skips re-initialization, incorrectly surfacing the error.
**Root Cause:** Session ID check and re-initialization decision are not atomic; a concurrent 404 can clear the ID between the check and the re-init attempt.
**Impact:** MCP client fails to reconnect when sessions terminate under concurrent load.
**Severity:** Medium
An automated fix proposal may be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] rmqctl skips MCP session re-initialization when a 404 races a concurrent send [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4880: [Bug] rmqctl skips MCP session re-initialization when a 404 races a concurrent send
URL: https://github.com/apache/rocketmq-dashboard/issues/4880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] rmqctl skips MCP session re-initialization when a 404 races a concurrent send [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4880:
URL: https://github.com/apache/rocketmq-dashboard/issues/4880#issuecomment-5943196447
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] rmqctl skips MCP session re-initialization when a 404 races a concurrent send [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #4880:
URL: https://github.com/apache/rocketmq-dashboard/issues/4880#issuecomment-6264928294
Resolved by #4876 (merged into rocketmq-studio as b88aedc34). Reopened from not_planned because the fix did land.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org