You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2015/01/17 21:26:36 UTC
[jira] [Comment Edited] (SOLR-6902) Use JUnit rules instead of
inheritance with distributed Solr tests to allow for multiple tests without
the same class
[ https://issues.apache.org/jira/browse/SOLR-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281526#comment-14281526 ]
Erick Erickson edited comment on SOLR-6902 at 1/17/15 8:26 PM:
---------------------------------------------------------------
Still doesn't pass precommit though, now the error is something about unbalanced </ul> in BaseDistributedSeachTestCase.ShardsRepeat.html. I may have some time to track this later this weekend...
And, of course, as near as I can tell the generated file does _not_ have any unbalanced <ul></ul> tags. Siiiigggghhhh,
was (Author: erickerickson):
Still doesn't pass precommit though, now the error is something about unbalanced </ul> in BaseDistributedSeachTestCase.ShardsRepeat.html. I may have some time to track this later this weekend...
> Use JUnit rules instead of inheritance with distributed Solr tests to allow for multiple tests without the same class
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-6902
> URL: https://issues.apache.org/jira/browse/SOLR-6902
> Project: Solr
> Issue Type: Improvement
> Components: Tests
> Reporter: Ramkumar Aiyengar
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-6902.patch, SOLR-6902.patch, SOLR-6902.patch
>
>
> Finally got annoyed enough with too many things being clubbed into one test method in all distributed Solr tests (anything inheriting from {{BaseDistributedSearchTestCase}} and currently implementing {{doTest}})..
> This just lays the groundwork really for allowing multiple test methods within the same class, and doesn't split tests as yet or flatten the inheritance hierarchy (when abused for doing multiple tests), as this touches a lot of files by itself. For that reason, the sooner this is picked up the better..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org