Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

[Puneet Gupta <pu...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review195018
-----------------------------------------------------------




lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 231-235 (patched)
<https://reviews.apache.org/r/64779/#comment274119>

    Is this required for restoreSession(...)flow only?  If yes can we move it there ?



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 236 (patched)
<https://reviews.apache.org/r/64779/#comment274118>

    Why is this required ?
    This method is called from openSession(..) and restoreSession(). The openSession call is already synchronized on sessionUser and the restoreSession happens in a single thread wand should not require synchronization.



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 350 (patched)
<https://reviews.apache.org/r/64779/#comment274120>

    This should not be required now since we are adding missing users to this map on restoreSession.


- Puneet Gupta


On Dec. 21, 2017, 3:40 p.m., Rajitha R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2017, 3:40 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1497
>     https://issues.apache.org/jira/browse/LENS-1497
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> NPE fix in closing idle connections
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434 
> 
> 
> Diff: https://reviews.apache.org/r/64779/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajitha R
> 
>