You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chris Suich <ch...@netapp.com> on 2013/12/04 16:11:11 UTC
Review Request 16001: ListViews marked with 'needsRefresh' do not have
loading overlay removed on error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16001/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle and Jessica Wang.
Repository: cloudstack-git
Description
-------
ListView actions marked with 'needsRefresh' add a loading overlay before the action is performed. If the operation succeeds, the overlay is properly removed. If it fails, the overlay is NOT removed.
I fixed this issue by adding the appropriate JS to remove the overlay when an error occurs during the operation.
This is for JIRA-5368. If accepted, please apply to 4.3 branch as well.
Diffs
-----
ui/scripts/ui/widgets/listView.js 53b37f1
Diff: https://reviews.apache.org/r/16001/diff/
Testing
-------
Thanks,
Chris Suich
Re: Review Request 16001: ListViews marked with 'needsRefresh' do not have
loading overlay removed on error
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16001/#review29737
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Dec. 4, 2013, 3:11 p.m., Chris Suich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16001/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 3:11 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> ListView actions marked with 'needsRefresh' add a loading overlay before the action is performed. If the operation succeeds, the overlay is properly removed. If it fails, the overlay is NOT removed.
>
> I fixed this issue by adding the appropriate JS to remove the overlay when an error occurs during the operation.
>
> This is for JIRA-5368. If accepted, please apply to 4.3 branch as well.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/listView.js 53b37f1
>
> Diff: https://reviews.apache.org/r/16001/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Suich
>
>