You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/14 11:32:39 UTC

[GitHub] [spark] zero323 commented on pull request #34892: [SPARK-37620][PYTHON] Use more precise types for SparkContext Optional fields (i.e. _gateway, _jvm)

zero323 commented on pull request #34892:
URL: https://github.com/apache/spark/pull/34892#issuecomment-993450521


   > @zero323 Should we use `cast` or `assert`? I think `assert` makes more sense because for example, it might be problematic to `cast` a `None` to `SparkContext`.
   
   Yup, let's go with `assert`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org