[jira] Commented: (THRIFT-260) Some Protocol methods shouldn't have default nil implementations

["Kevin Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683694#action_12683694 ] 

Kevin Clark commented on THRIFT-260:
------------------------------------

Looks fine, push it.

> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
>                 Key: THRIFT-260
>                 URL: https://issues.apache.org/jira/browse/THRIFT-260
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Trivial
>             Fix For: 0.1
>
>         Attachments: thrift-260.patch
>
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.