[jira] Commented: (DIRMINA-143) SocketAcceptor.bind() should fillInStackTrace() before rethrowing exception

["Niklas Therning (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/DIRMINA-143?page=comments#action_12359862 ] 

Niklas Therning commented on DIRMINA-143:
-----------------------------------------

How about wrapping the original exception in a new IOException instead of using fillInStackTrace()? The message of the new exception would then indicate the port which couldn't be bound to. Or will that be too messy?

There might be a philosophy behind using fillInStackTrace() instead of wrapping? I usually prefer wrapping since then I won't miss out on any info that could be useful. Sometimes it can become very messy. In this case, however, I think it will be ok.


> SocketAcceptor.bind() should fillInStackTrace() before rethrowing exception
> ---------------------------------------------------------------------------
>
>          Key: DIRMINA-143
>          URL: http://issues.apache.org/jira/browse/DIRMINA-143
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.8.1
>     Reporter: Walter Tam
>     Priority: Minor

>
> When SocketAcceptor.bind() encounters an exception returned from the bind request, it simply rethrows. The resulting stack trace is from the underlying registration thread which is not very helpful when debugging the cause. Other similar places like SocketAcceptor.unbind(), DatagramAcceptor.unbind() does a fillInStackTrace()  before re throwing. 
> Also it will be helpful in this case to add the port number that failed to the message

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira