[GitHub] [accumulo] ctubbsii opened a new issue, #2698: TabletLocatorImplTest has utterly incomprehensible method and variable names and little documentation

[GitBox <gi...@apache.org>]

ctubbsii opened a new issue, #2698:
URL: https://github.com/apache/accumulo/issues/2698

   The TabletLocatorImplTest has method names that are very obfuscated.
   
   Some of the names are a bit more obvious, like `nke == new KeyExtent`, `nr == new Range`, etc.
   
   But then, there's utterly incomprehensible method names, like `cemb`, which uses variable names like `ols` (which I guess is a plural `ol` which is an Object list, even though it's actually an array, not a List), and `emb` (which is a `new HashMap<String,Map<KeyExtent,List<String>>>`) and I have no idea what any of this is doing, as it's not documented.
   
   A lot of this class also relies on Object arrays, and just casting to the specific type that is expected to be at a specific position in the array.
   
   There's a *lot* of room for improvement. Simply giving the methods and variables better names to match what they are for would help. But also, getting rid of the use of Arrays and using Streams, or more strongly typed objects to avoid casting would also help. Where complexity is needed, some guiding hints in comments could help the reader understand what the intent is.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] dlmarion closed issue #2698: TabletLocatorImplTest has utterly incomprehensible method and variable names and little documentation

[GitBox <gi...@apache.org>]

dlmarion closed issue #2698: TabletLocatorImplTest has utterly incomprehensible method and variable names and little documentation
URL: https://github.com/apache/accumulo/issues/2698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org