You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Jørgen Løland (JIRA)" <ji...@apache.org> on 2007/04/26 14:25:15 UTC

[jira] Created: (DERBY-2595) junit tests uses getExportedKeys with table name null

junit tests uses getExportedKeys with table name null
-----------------------------------------------------

                 Key: DERBY-2595
                 URL: https://issues.apache.org/jira/browse/DERBY-2595
             Project: Derby
          Issue Type: Bug
          Components: Test
    Affects Versions: 10.2.2.0
            Reporter: Jørgen Løland


org.apache.derbyTesting.junit.JDBC.dropSchema uses DatabaseMetadata#getExportedKeys with null as table name. This is not allowed according to java.sql.DatabaseMetaData. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-2595) junit tests uses getExportedKeys with table name null

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland closed DERBY-2595.
--------------------------------


> junit tests uses getExportedKeys with table name null
> -----------------------------------------------------
>
>                 Key: DERBY-2595
>                 URL: https://issues.apache.org/jira/browse/DERBY-2595
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.2.2.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2595-1.diff, DERBY-2595-1.stat
>
>
> org.apache.derbyTesting.junit.JDBC.dropSchema uses DatabaseMetadata#getExportedKeys with null as table name. This is not allowed according to java.sql.DatabaseMetaData. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2595) junit tests uses getExportedKeys with table name null

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2595:
---------------------------------

    Derby Info: [Patch Available]

> junit tests uses getExportedKeys with table name null
> -----------------------------------------------------
>
>                 Key: DERBY-2595
>                 URL: https://issues.apache.org/jira/browse/DERBY-2595
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.2.2.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-2595-1.diff, DERBY-2595-1.stat
>
>
> org.apache.derbyTesting.junit.JDBC.dropSchema uses DatabaseMetadata#getExportedKeys with null as table name. This is not allowed according to java.sql.DatabaseMetaData. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DERBY-2595) junit tests uses getExportedKeys with table name null

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland reassigned DERBY-2595:
------------------------------------

    Assignee: Jørgen Løland

> junit tests uses getExportedKeys with table name null
> -----------------------------------------------------
>
>                 Key: DERBY-2595
>                 URL: https://issues.apache.org/jira/browse/DERBY-2595
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.2.2.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>
> org.apache.derbyTesting.junit.JDBC.dropSchema uses DatabaseMetadata#getExportedKeys with null as table name. This is not allowed according to java.sql.DatabaseMetaData. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2595) junit tests uses getExportedKeys with table name null

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492457 ] 

Jørgen Løland commented on DERBY-2595:
--------------------------------------

Thanks for committing the patch, Knut.

> junit tests uses getExportedKeys with table name null
> -----------------------------------------------------
>
>                 Key: DERBY-2595
>                 URL: https://issues.apache.org/jira/browse/DERBY-2595
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.2.2.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2595-1.diff, DERBY-2595-1.stat
>
>
> org.apache.derbyTesting.junit.JDBC.dropSchema uses DatabaseMetadata#getExportedKeys with null as table name. This is not allowed according to java.sql.DatabaseMetaData. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-2595) junit tests uses getExportedKeys with table name null

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen resolved DERBY-2595.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.3.0.0
       Derby Info:   (was: [Patch Available])

Thanks, Jørgen! Committed revision 533175.
I noticed that the old code only committed the transaction once after dropping all the foreign keys, whereas the patch would commit once for each table. I changed back to the old behaviour before committing.

> junit tests uses getExportedKeys with table name null
> -----------------------------------------------------
>
>                 Key: DERBY-2595
>                 URL: https://issues.apache.org/jira/browse/DERBY-2595
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.2.2.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2595-1.diff, DERBY-2595-1.stat
>
>
> org.apache.derbyTesting.junit.JDBC.dropSchema uses DatabaseMetadata#getExportedKeys with null as table name. This is not allowed according to java.sql.DatabaseMetaData. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2595) junit tests uses getExportedKeys with table name null

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2595:
---------------------------------

    Attachment: DERBY-2595-1.stat
                DERBY-2595-1.diff

Modified org/apache/derbyTesting/junit/JDBC#dropSchema. 

Instead of 
----------
rs = getExportedKeys(schema, null,...) //tablename = null
while (rs.next()){...}

It now performs
---------------
ResultSet tables = getTables(schema,...);
while (tables.next()){
  rs = getExportedKeys(schema, tables.getString("TABLE_NAME"), ...)
  while (rs.next()){...}
}

This is in compliance with the JDBC API. allsuites runs without failures/errors. derbyall not run because only junit test code is modified. 

> junit tests uses getExportedKeys with table name null
> -----------------------------------------------------
>
>                 Key: DERBY-2595
>                 URL: https://issues.apache.org/jira/browse/DERBY-2595
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.2.2.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-2595-1.diff, DERBY-2595-1.stat
>
>
> org.apache.derbyTesting.junit.JDBC.dropSchema uses DatabaseMetadata#getExportedKeys with null as table name. This is not allowed according to java.sql.DatabaseMetaData. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.