You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/27 01:08:08 UTC

[GitHub] [spark] panbingkun opened a new pull request, #41336: [SPARK-43821][CONNECT][TESTS] Make the prompt for `findJar` method in IntegrationTestUtils clearer

panbingkun opened a new pull request, #41336:
URL: https://github.com/apache/spark/pull/41336

   ### What changes were proposed in this pull request?
   The pr aims to make the prompt for `findJar` method in IntegrationTestUtils clearer.
   
   ### Why are the changes needed?
   When I am running tests in ClientE2ETestSuite, I often cannot locate them through error prompts when they fail, and I can only search for specific reasons through code
   
   - Before applying this patche, the error prompt is as follows:
   `Exception encountered when invoking run on a nested suite - Failed to find the jar inside folder: .../spark-community/connector/connect/server/target`
   
   - After applying this patche, The error prompt is as follows:
   `Exception encountered when invoking run on a nested suite - Failed to find the jar: spark-connect-assembly(.).jar or spark-connect(.)3.5.0-SNAPSHOT.jar inside folder: .../spark-community/connector/connect/server/target. This file can be generated by similar to the following command: build/sbt package|assembly`
   
   Improvement in two aspects
   - Prompt us what files are missing
   - How to generate the above file
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Manual check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #41336: [SPARK-43821][CONNECT][TESTS] Make the prompt for `findJar` method in IntegrationTestUtils clearer

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #41336: [SPARK-43821][CONNECT][TESTS] Make the prompt for `findJar` method in IntegrationTestUtils clearer
URL: https://github.com/apache/spark/pull/41336


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on a diff in pull request #41336: [SPARK-43821][CONNECT][TESTS] Make the prompt for `findJar` method in IntegrationTestUtils clearer

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41336:
URL: https://github.com/apache/spark/pull/41336#discussion_r1208035872


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -102,9 +102,14 @@ object IntegrationTestUtils {
       sbtName: String,
       mvnName: String,
       test: Boolean = false): File = {
-    val jar = tryFindJar(path, sbtName, mvnName, test).getOrElse(
-      throw new RuntimeException(
-        s"Failed to find the jar inside folder: ${getTargetFilePath(path)}"))
+    val jar = tryFindJar(path, sbtName, mvnName, test).getOrElse({

Review Comment:
   cc @zhenlineo 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org