You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "cziegeler (via GitHub)" <gi...@apache.org> on 2023/07/18 14:15:20 UTC
[GitHub] [sling-org-apache-sling-engine] cziegeler opened a new pull request, #38: SLING-11970 : Avoid restarting of components on configuration change
cziegeler opened a new pull request, #38:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #38: SLING-11970 : Avoid restarting of components on configuration change
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #38:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#issuecomment-1642330344
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=38)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG) [5 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_coverage&view=list) [13.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_duplicated_lines_density&view=list)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] cziegeler merged pull request #38: SLING-11970 : Avoid restarting of components on configuration change
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler merged PR #38:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #38: SLING-11970 : Avoid restarting of components on configuration change
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #38:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#issuecomment-1642335198
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=38)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG) [5 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_duplicated_lines_density&view=list)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #38: SLING-11970 : Avoid restarting of components on configuration change
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #38:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#issuecomment-1641909698
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=38)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG) [7 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_coverage&view=list) [2.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_duplicated_lines_density&view=list)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] rombert commented on a diff in pull request #38: SLING-11970 : Avoid restarting of components on configuration change
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on code in PR #38:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#discussion_r1268002616
##########
src/main/java/org/apache/sling/engine/impl/SlingRequestProcessorImpl.java:
##########
@@ -355,12 +361,22 @@ public void dispatchRequest(final ServletRequest request,
final RequestPathInfo resolvedURL,
final DispatchingInfo dispatchingInfo)
throws IOException, ServletException {
-
// we need a SlingHttpServletRequest/SlingHttpServletResponse tupel
// to continue
final SlingHttpServletRequest cRequest = RequestData.toSlingHttpServletRequest(request);
final SlingHttpServletResponse cResponse = RequestData.toSlingHttpServletResponse(response);
+ // check that we have all required services
+ final ServletResolver sr = this.servletResolver;
+ if (sr == null) {
+ final int status = HttpServletResponse.SC_SERVICE_UNAVAILABLE;
+ String errorMessage = "Required service missing (ServletResolver)";
+ log.debug("{}), cannot dispatch requests, sending status {}", errorMessage, status);
Review Comment:
@cziegeler - there seems to be a stray `)` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #38: SLING-11970 : Avoid restarting of components on configuration change
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #38:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#issuecomment-1640401329
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=38)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=38&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=38&metric=new_duplicated_lines_density&view=list)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] cziegeler commented on a diff in pull request #38: SLING-11970 : Avoid restarting of components on configuration change
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on code in PR #38:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#discussion_r1268072945
##########
src/main/java/org/apache/sling/engine/impl/SlingRequestProcessorImpl.java:
##########
@@ -355,12 +361,22 @@ public void dispatchRequest(final ServletRequest request,
final RequestPathInfo resolvedURL,
final DispatchingInfo dispatchingInfo)
throws IOException, ServletException {
-
// we need a SlingHttpServletRequest/SlingHttpServletResponse tupel
// to continue
final SlingHttpServletRequest cRequest = RequestData.toSlingHttpServletRequest(request);
final SlingHttpServletResponse cResponse = RequestData.toSlingHttpServletResponse(response);
+ // check that we have all required services
+ final ServletResolver sr = this.servletResolver;
+ if (sr == null) {
+ final int status = HttpServletResponse.SC_SERVICE_UNAVAILABLE;
+ String errorMessage = "Required service missing (ServletResolver)";
+ log.debug("{}), cannot dispatch requests, sending status {}", errorMessage, status);
Review Comment:
thanks, will be removed with the next update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org