[GitHub] [kafka] hachikuji commented on a diff in pull request #11784: KAFKA-13228; Ensure ApiVersionRequest is properly handled KRaft co-resident mode

[GitBox <gi...@apache.org>]

hachikuji commented on code in PR #11784:
URL: https://github.com/apache/kafka/pull/11784#discussion_r910511854


##########
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##########
@@ -254,7 +256,7 @@ class BrokerToControllerChannelManagerImpl(
   def controllerApiVersions(): Option[NodeApiVersions] = {
     requestThread.activeControllerAddress().flatMap { activeController =>
       if (activeController.id == config.brokerId)
-        Some(currentNodeApiVersions)
+        currentNodeControllerApiVersions

Review Comment:
   I wonder if this optimization is worth preserving. Any harm using the same negotiation even when the controller is co-resident? 



##########
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##########
@@ -77,25 +76,14 @@ object AlterPartitionManager {
   def apply(
     config: KafkaConfig,
     metadataCache: MetadataCache,
+    alterPartitionChannelManager: BrokerToControllerChannelManager,

Review Comment:
   nit: I think `alterPartition` is redundant here. Could we call it `channelManager`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org