You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/11/28 13:03:47 UTC

[GitHub] [fineract] b0c1 commented on a diff in pull request #2771: FINERACT-1724

b0c1 commented on code in PR #2771:
URL: https://github.com/apache/fineract/pull/2771#discussion_r1033516577


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -2119,6 +2119,10 @@ public CommandProcessingResult undoWriteOff(Long loanId) {
         }
         LocalDate recalculateFrom = null;
         LoanTransaction writeOffTransaction = loan.findWriteOffTransaction();
+        if (writeOffTransaction == null) {

Review Comment:
   I think it will fail later at row 2152 where 
   ```java
   .withEntityId(writeOffTransaction.getId()) //
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org