You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/04 16:53:46 UTC

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #5799: [TE] Fix issue of not loading RCA template when metricid is not specified

harleyjj commented on a change in pull request #5799:
URL: https://github.com/apache/incubator-pinot/pull/5799#discussion_r465191989



##########
File path: thirdeye/thirdeye-frontend/app/pods/rootcause/route.js
##########
@@ -296,13 +312,16 @@ export default Route.extend(AuthenticatedRouteMixin, {
       session,
       anomalyId,
       anomalyUrn,
-      anomalyEntity,
+      anomalyTemplateEntity,
       contextUrnsPredefined,
       selectedUrnsPredefined,
-      anomalyUrnsPredefined,
-      metricTemplate
+      anomalyUrnsPredefined
     } = model;
 
+    // The metric 

Review comment:
       Could you put a comment here on why we do this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org